[Net-ssleay-devel] Bug#551007: please add ripemd160 digest to libnet-ssleay-perl

Daniel Kahn Gillmor dkg at fifthhorseman.net
Fri Oct 16 21:14:18 UTC 2009


On 10/16/2009 12:21 AM, Daniel Kahn Gillmor wrote:
> The revised patch is attached, and should apply cleanly to the
> current svn trunk (r255).

Thanks for applying the RIPEMD160 patch, Mike!

I just noticed that the QuickRef hashfunction section has a header that
refers to MD5 but nothing else.  Someone grepping the QuickRef for other
digests (e.g. MD4) might not find what they're looking for.

The attached patch genericizes the section header, includes a comment
with the known exported digests, and prefixes the trailing comment with
the # symbol to match the style of the subsequent section.

hope it's helpful,

	--dkg

PS it looks like the lines in 50_digest.t now have mixed tabs and spaces
on the ripemd lines though the indents on the md* lines are all-spaces.
 i hope my patch didn't cause that somehow -- the whitespace differences
caused a conflict for me when i tried to "svn update". bleah.  Anyway, i
thought i'd let you know if you care about nit-picky things like
whitespace consistency :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: digest-quickref.diff
Type: text/x-diff
Size: 948 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/net-ssleay-devel/attachments/20091016/497146c8/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 891 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/net-ssleay-devel/attachments/20091016/497146c8/attachment.pgp>


More information about the Net-ssleay-devel mailing list