[Nut-upsdev] Replace target.line and target.battery?
selinger at mathstat.dal.ca
Mon Feb 13 17:43:10 UTC 2006
No objections at all. I looked at all the drivers, and the only one
that seems to differentiate between "output.voltage.target.line" and
"output.voltage.target.battery" is drivers/esupssmart.c, and that
driver doesn't seem to be too sure of what it is doing (it is setting
output.voltage.target.line to something called "INFO_NOM_IN_VOLT",
which would seem to be the nominal *input* voltage?
So I agree that output.voltage.nominal makes a lot more sense.
No problem for apc-hid.c, mge-hid.c.
Niklas Edmundsson wrote:
> On Mon, 13 Feb 2006, Niklas Edmundsson wrote:
> > Noone has objected to this, so I'll whip up a patch that implements the
> > change in docco and all related drivers. Since it's a rather simple change I
> > don't expect too many things to break.
> And here's the patch. It touches the following drivers, and although
> it shouldn't break stuff I'd feel better if those who feels
> responsible for the respective drivers took a look at it before it
> lands in CVS:
> M drivers/al175.c
> M drivers/apc-hid.c
> M drivers/apcsmart.h
> M drivers/dummy-ups.h
> M drivers/esupssmart.c
> M drivers/megatec.c
> M drivers/mge-hid.c
> M drivers/mge-shut.h
> M drivers/nitram.c
> M drivers/oneac.c
> M drivers/tripplite-hid.c
> M drivers/tripplitesu.c
> I have verified this myself (it's part of the snmp driver):
> M drivers/apccmib.h
More information about the Nut-upsdev