[Nut-upsdev] Fwd: DeviceKit-power patches

Arnaud Quette aquette.dev at gmail.com
Thu Jun 26 14:13:50 UTC 2008


2008/6/26 Arjen de Korte <nut+devel at de-korte.org>:
>>> I've just tested: it i fine with key=info.subsystem.
>>>
>>> But it is not (as you say) "the entry matching my unit", it is at the
>>> top level:
>>>
>>> <?xml version="1.0" encoding="ISO-8859-1"?> <!-- -*- SGML -*- -->
>>> <deviceinfo version="0.2">
>>>   <device>
>>>     <match key="info.subsystem" string="usb_device">
>>
>> Yep that the only place you find 'info.bus'. Nice that it solved the
>> problem. It would be safe to fix this in the svn, as I think all that
>> is testing it is running a newer hal. Se if Arnaud do that. (Or I submit
>> it.)
>
> I think we'd better check for the HAL version through some autoconf magic,
> so that we don't break things if this assumption proves to be incorrect.
> We already have a 'nut_check_libhal.m4' file that detects the HAL version,
> changing it to also set this would be trivial. I'll see if I can find the
> time to do this (no promises though). Do you know the change date for
> this?

that's also my point of view.
imo, >= to HAL 0.5.11, since 0.5.10 was working (everybody confirm?)

if somebody can take over the trunk side, I'm fine. Otherwise, I'll do it.
it's simply a matter of creation a .fdi.in, conditioning the mentioned
field, testing the HAL version in check_hal.m4 and outputing the final
.fdi from the scripts/hal/Makefile.am

Arnaud
-- 
Linux / Unix Expert R&D - MGE Office Protection Systems - http://www.mgeops.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://people.debian.org/~aquette/
Free Software Developer - http://arnaud.quette.free.fr/



More information about the Nut-upsdev mailing list