[Nut-upsdev] patch for support Liebert GXT2 ESP2 protocol
Arjen de Korte
nut+devel at de-korte.org
Wed Jan 13 21:55:09 UTC 2010
Citeren Richard Gregory <R.Gregory op liverpool.ac.uk>:
> Attached is a patch against nut-2.4.1 that adds a driver for the ESP2
> protocol, as used by the serial port found on the Liebert GXT2.
Thanks for this driver. We really appreciate this. A couple of remarks:
1) Don't patch Makefile.in files (these will be generated by autoconf)
2) Have a look at the developer documentation, especially
- docs/developers.txt ('Portability', 'Indenting', 'Spaghetti')
The dstate_setinfo() function takes a formatted string (there is no
need for snprintf() here).
Especially for experimental drivers, use lots of debugging. If people
attempt to add other models and get unexpected results, we want to
know what is happening. The upsdebugx() and upsdebug_with_errno()
functions are your friend.
Try to cut down on casting of variables.
Best regards, Arjen
Please keep list traffic on the list
More information about the Nut-upsdev