[Nut-upsdev] blzr_voltronic.c

[Charles Lepple]

Daniele,

I was going to try and put a comment on GitHub, but apparently there isn't a pull request open for your new 'blzr' branch.

This line is tripping up the Debian build:

https://github.com/zykh/nut/blob/69d79a65789cf479ceb2d6173de4c5b5315ccc50/drivers/blzr_voltronic.c#L2827

http://buildbot.networkupstools.org/public/nut/builders/Debian-x64-gcc/builds/57

../../drivers/blzr_voltronic.c: In function ‘voltronic_fault’:
../../drivers/blzr_voltronic.c:2827:3: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors
make[3]: *** [blzr-blzr_voltronic.o] Error 1

I would recommend adding a "%s" format string at the very least, but while you are looking at that, would it make sense to add a description of what is being logged, or would that be redundant? (I haven't had a chance to see how this function is called.)

-- 
Charles Lepple
clepple at gmail