Hi Kirill,<br><br>
sorry for the long delay in answering...<br>
<br>
I've merged, in the CVS development tree, a modified version of your driver. What I've done:<br>
- created al175.h for consistency<br>
- disabled (not removed) non conformant vars and status<br>
- remove the "goto". <br>
- modified man/Makefile.in<br>
<br>
Please test it, and ack back.<br>
some more info below...<br>
<br><div><span class="gmail_quote">2005/9/28, Kirill Smelkov <<a href="mailto:kirr@mns.spb.ru">kirr@mns.spb.ru</a>>:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hello up there!<br><br>This is my 2nd try.<br>Please ACK or NAK this.<br><br>--- on 21-SEP-2005 I wrote ---<br>Hi Arnaud,<br>Thank you for your reply!<br><br>...<br>
</blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> * you should use the internal xmalloc() function<br>
done. do you have any objections againts raw_alloca?</blockquote><div><br>
none, just advices ;-)<br>
</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">...<br>> More generally, please read the following to ensure you comply with NUT
<br>> standard for coding, variables names, ... :<br>
> <a href="http://eu1.networkupstools.org/doc/2.0.1/developers.html">http://eu1.networkupstools.org/doc/2.0.1/developers.html</a><br>> <a href="http://eu1.networkupstools.org/doc/2.0.1/new-drivers.html">http://eu1.networkupstools.org/doc/2.0.1/new-drivers.html
</a><br>> <a href="http://eu1.networkupstools.org/doc/2.0.1/new-names.html">http://eu1.networkupstools.org/doc/2.0.1/new-names.html</a><br>Ugh...<br>I changed some things, like sprintf -> snprintf, exit -> fatal, etc...
<br>Is it ok now?</blockquote><div><br>
yes, fine thanks. <br>
</div>there are still things left, like:<br>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">- DEBUG should be removed: have a look at mge-shut.c/dump_hex()<br>
More generally, have a look at upslogx and upsdebugx possibilities.<br>
These allows runtime tracing, for logging (into syslog and alike) or debugging, without the need to recompile.<br>
- indent: <a href="http://eu1.networkupstools.org/doc/2.0.1/developers.html">http://eu1.networkupstools.org/doc/2.0.1/developers.html</a><br>
Use tab please!<br>
- alarm_handler()!<br>
<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> Please, correct the above, and discuss on upsdev the variables problem...<br>As to new variables:
<br>Is it possible to comment or not include at all code that sets them?</blockquote><div><br>
that's what I've done. So you still have these for further use</div></div><br>
I hope I've not forgotten anything, but I don't make promise ;-)<br>
Thanks again,<br clear="all">Arnaud<br>-- <br>Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt<br>Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org/">http://www.networkupstools.org/
</a><br>Debian Developer - <a href="http://people.debian.org/%7Eaquette/">http://people.debian.org/~aquette/</a><br>OpenSource Developer - <a href="http://arnaud.quette.free.fr/">http://arnaud.quette.free.fr/</a>