<br><div><span class="gmail_quote">2005/12/19, Julius P. Malkiewicz <<a href="mailto:julius@sonartech.com.au">julius@sonartech.com.au</a>>:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Mon, Dec 19, 2005 at 09:07:18AM +0100, Arnaud Quette wrote:<br>> Hi guys,<br>><br>> before working on a point, contact me first!<br>> The SEC driver as already been resurected as gamatronic in the Dev and<br>
> Testing tree...<br><br>Ah .. the testing branch ... (I don't think I was aware of it).</blockquote><div><br>
things have changed a lot since I've taken over NUT.<br>
The development is now more open and transparent... But there is still a lot to do.<br>
</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">I did attempt search for new work on the sec driver ... obviously I missed<br>that it had been (temporarily) renamed to gamatronic :).
</blockquote><div><br>
the CHANGES file is the best place to search for such things ;-)<br>
</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> Thanks to check this one for merging changes.<br><br>Hmm ... a quick look indicates that the two efforts are different ... I've
<br>modified the code quite extensively to make it (what I hope) is more readable<br>... also support for instcmd are made. gamatronic has alarm support (I<br>didn't add as the documentation wasn't the clearest ...)<br><br>
However, the big difference I see is that the serial port reader (sec_upsrecv)<br>uses ser_get_line with ENDCHAR ... which seems to be against the SEC protocol,<br>(as per <a href="http://www.networkupstools.org/protocols/sec.html">
http://www.networkupstools.org/protocols/sec.html</a>), and indeed won't<br>work with the Belkin UPS I have here ... (no end-of-line delimiter is<br>transmitted, as per SEC spec).<br><br> Unless I'm mistaken, the gamatronic driver will not work for any SEC-based device because of this :(.
<br><br> I guess that leads to a problem, with a solution which probably involves a<br>library to share the common bits between different "veneer" comms protocols.<br><br> I feel my code is a little cleaner, and should be used as "the" sec driver,
<br>but won't be offended if that's not the case :) ...<br></blockquote></div><br>what
I propose is that you (Julius and Nadav) synchronise on that to check
how these 2 drivers could be merged into one, with an option (upstype,
or whatever) to switch this endchar, if the technical changes are
limited to that. If the difference are more important, a share code +
subdrivers / drivers can be the way.<br clear="all"><br>
Note that I haven't looked at your (Julius) code...<br>
<br>
Arnaud<br>-- <br>Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt<br>Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org/">http://www.networkupstools.org/</a><br>Debian Developer - <a href="http://people.debian.org/~aquette/">
http://people.debian.org/~aquette/</a><br>OpenSource Developer - <a href="http://arnaud.quette.free.fr/">http://arnaud.quette.free.fr/</a>