<br><br><div><span class="gmail_quote">2006/7/7, Peter Selinger <<a href="mailto:selinger@mathstat.dal.ca" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">selinger@mathstat.dal.ca</a>>:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Silvino,<br><br>thanks for your work on this driver. Are you sure the new patch is in<br>English?</blockquote><div><br>in fact, it's in english for solis but not for rhino.<br>I've fixed the latter and included it in Testing for
2.0.4-pre2. <br></div></div><br>Some more comments and questions:<br>- I've got a link error with rhino on « pow ». I've modified gendb to include "-lm" (link against libmath)...<br>- outlet.0 is equal to ups. The first real outlet is outlet1...
<br>are you sure about your outlet0<br>- the values for outlet.* are lower case (ie Yes/No => yes/no). Also fixed.
<br>- can't rhino and solis drivers be merged (into ie a microsol driver), including some protocol detection mechanism or switch parameter? The more shared code and the less driver, the better,<br>- avoid "printf" and prefer either upsdebug/upsdebugx instead,
<br>- avoid malloc() and prefer xmalloc()<br>=> more generally, check <a href="http://eu1.networkupstools.org/doc/2.0.1/developers.html" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://eu1.networkupstools.org/doc/2.0.1/developers.html
</a><br>- as told previously, prefer english comments and variables name. That make life easier for maintainers and contributors.
<br><br>Please, check for correcting all these when you have a bit of time. After that, we'll be able to check for joining the team ;-)<br><br>Arnaud<br>-- <br>Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt
<br>Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://www.networkupstools.org/</a><br>Debian Developer - <a href="http://people.debian.org/%7Eaquette/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
http://people.debian.org/~aquette/
</a><br>OpenSource Developer - <a href="http://arnaud.quette.free.fr/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://arnaud.quette.free.fr/</a>