<br><br><div class="gmail_quote">2010/3/22 Charles Lepple <span dir="ltr"><<a href="mailto:clepple@gmail.com">clepple@gmail.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Mar 19, 2010, at 1:21 PM, Arnaud Quette wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
[...]<div class="im"><br>
At r2403, the code does not force the creation of a ChangeLog if a<br>
user simply checks out the source, then runs autoreconf, configure and<br>
make. I am wondering if we should remove the "|| echo" portion, and<br>
simply add a "touch ChangeLog" on the buildslaves that don't have<br>
svn2cl (and wouldn't need it, since they are not all distributing<br>
tarball snapshots).<br>
</div></blockquote><div class="im">
<br>
nice job.<br>
I'm in favor of keeping the failure warning msg, while touching ChangeLog.<br>
note that I haven't yet had a chance to test it though.<br>
</div></blockquote>
<br>
Hmm, maybe I misinterpreted "keeping the failure warning message".<br></blockquote><div>Â <br>I was not quite clear indeed!<br>echo "svn2cl failed to generate the ChangeLog. See <a href="http://trac.networkupstools.org/projects/nut/timeline" target="_blank">http://trac.networkupstools.org/projects/nut/timeline</a>" > ChangeLog<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Anyway, I dropped the "|| echo" portion (so if svn2cl fails, or is not found, the build fails), and tried to run "touch ChangeLog" for all but the Debian etch host (since that one generates web-accessible tarballs). The problem is that the build really happens twice - once to check and see if it builds in-place, then once to see if it builds from the tarball it is generating.<br>
<br>
Here are the results:<br>
<br>
<a href="http://buildbot.networkupstools.org/public/nut/builders/FreeBSD-x86/builds/118" target="_blank">http://buildbot.networkupstools.org/public/nut/builders/FreeBSD-x86/builds/118</a><br>
<br>
I'm not sure of an easy way to inject the dummy ChangeLog. Would it be too annoying to require svn2cl (or at least a placeholder script that does nothing)? Should I add an autoconf parameter for this?<font color="#888888"><br>
</font></blockquote></div><br>hmm, I don't think that failing is necessary here. <br>putting the above msg into ChangeLog is fine. also echo'ing it would be a plus.<br>the cherry for maintainability would be an "UP_TO_VERSION" param that get the revision number, using something like:<br>
svn log -v -q --stop-on-copy svn://<a href="http://svn.debian.org/nut/tags/v2.4.3">svn.debian.org/nut/tags/v2.4.3</a><br><br>cheers,<br>Arnaud<br>