Hi Michal,<br><br><div class="gmail_quote">2011/3/21 Michal Soltys <span dir="ltr"><<a href="mailto:soltys@ziu.info" target="_blank">soltys@ziu.info</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Before I start any commits.<br>
<br>
In patch 2/18 -<br>
<a href="http://lists.alioth.debian.org/pipermail/nut-upsdev/2011-March/005299.html" target="_blank">http://lists.alioth.debian.org/pipermail/nut-upsdev/2011-March/005299.html</a><br>
<br>
Two "custom" commands slipped in: ups.firmware.old and<br>
shutdown.return.grace. In 18/18 I tried to rename them and add<br>
remainig commands for "hackish" shutdown methods, to make them easily<br>
callable through e.g. upscmd (for example for testing).<br>
<br>
Is it acceptable to add certain commands specific only to some driver<br>
and documented in its manual page (but otherwise meaningless for the<br>
rest of the drivers) ? Say with (in this case) a driver prefix, e.g.:<br></blockquote><div><br>I would more be in favor of finally using the extra param of instcmd(const char *cmdname, const char *extra)<br>and mapping these commands onto existing ones. Specific parameters would then be described in manpages.<br>
<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
apcsmart.shutdown.grace (@nnn)<br>
apcsmart.shutdown.grace.h (@nn)<br></blockquote><div><br>could you please define (quite probably again, sorry) the meaning of the 2 above and shutdown.return.grace, so that I can propose something here?<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
apcsmart.shutdown.cs (force OB (U), then shutdown.return (S) - aka 'CS hack')<br></blockquote><div><br>this would give "shutdown.return cs"<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
apcsmart.firmware.old (V)<br></blockquote></div><br>I'm not sure to see how useful it is. Are they really storing the previous FW version?<br>and what is the use case?<br>is your unit filling ups.firmware + .aux + .old?<br>
if it's the case, ups.firmware.old has to be added.<br>otherwise, I'm not sure ups.firmware.aux would be a good option! <br clear="all"><br>cheers,<br>Arnaud<br>-- <br>Linux / Unix Expert R&D - Eaton - <a href="http://powerquality.eaton.com" target="_blank">http://powerquality.eaton.com</a><br>
Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org/" target="_blank">http://www.networkupstools.org/</a><br>Debian Developer - <a href="http://www.debian.org" target="_blank">http://www.debian.org</a><br>
Free Software Developer - <a href="http://arnaud.quette.free.fr/" target="_blank">http://arnaud.quette.free.fr/</a><br><br>