<br><br><div class="gmail_quote">2011/4/21 Michal Soltys <span dir="ltr"><<a href="mailto:soltys@ziu.info">soltys@ziu.info</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On 11-04-21 10:34, Arnaud Quette wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Lupe,<br>
<br>
since we now have an apcsmart maintainer, I'm forwarding this issue to him.<br>
<br>
@Michal: could you please have a look at this issue [1], and give us<br>
your feeling?<br>
<br>
cheers,<br>
Arnaud<br>
</blockquote>
<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
--<br>
[1] <a href="https://bugs.launchpad.net/bugs/535583" target="_blank">https://bugs.launchpad.net/bugs/535583</a><br>
<br>
2011/2/15 Lupe Christoph <<a href="mailto:lupe@lupe-christoph.de" target="_blank">lupe@lupe-christoph.de</a><br></div>
<mailto:<a href="mailto:lupe@lupe-christoph.de" target="_blank">lupe@lupe-christoph.de</a>>><br>
<br>
</blockquote>
<br>
The suggestions are pretty fine.<br>
<br>
- flushing stale input (though at driver level)<br>
<br>
Certainly. I even added some flushes earlier, but haven't touched the updateinfo and/or the functions it calls yet. I'll add it along with forthcoming patches (icanon mode and the rest). Looking at the strace, flushing post-failure might be good idea in certain cases as well.<br>
<br>
- reopening serial port<br>
<br>
If the upper layers of nut don't disallow this kind of behaviour for some reason - it's good idea as well. Should be helpful in weird cases, and at the very least wouldn't hurt at all. If it would help in this particular case, hard to say.<br>
</blockquote><div><br>none special. we already have to somehow do so with USB devices.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
- smartmode()<br>
<br>
TBH, I'm not sure why it diligently tries to enter SM 5 times. Pre-emptive flush + 'Y' + reasonable delay (icanon or not) should be all that is necessary. If we don't succeed, next attempt shouldn't miraculously (in theory) make much of a difference 1 second later ...<br>
<br>
<br>
Thanks for pointing out those issues.<br>
</blockquote></div><br>thanks for taking care of it ;-)<br><br>cheers,<br clear="all">Arnaud<br>-- <br>Linux / Unix Expert R&D - Eaton - <a href="http://powerquality.eaton.com" target="_blank">http://powerquality.eaton.com</a><br>
Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org/" target="_blank">http://www.networkupstools.org/</a><br>Debian Developer - <a href="http://www.debian.org" target="_blank">http://www.debian.org</a><br>
Free Software Developer - <a href="http://arnaud.quette.free.fr/" target="_blank">http://arnaud.quette.free.fr/</a><br><br>