<br><div class="gmail_quote">2012/11/6 Elio Parisi <span dir="ltr"><<a href="mailto:E.Parisi@riello-ups.com" target="_blank">E.Parisi@riello-ups.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">




<div link="blue" vlink="purple" lang="IT">
<p></p><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Arnaud,<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u></span></p>

</div></div></blockquote><div><br>Hi Elio, <br><br>thanks for jumping on the list ;)<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div link="blue" vlink="purple" lang="IT">

<div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">I change something in the driver to conform driver to your development rules: C++ style comments, space indentation and Italian comments.<u></u><u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u></span></p></div></div></blockquote><div><br>great, thanks.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="blue" vlink="purple" lang="IT"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">I have a question about “</span><span lang="EN-US">missing source reference of the derivative work (probably the blazer driver)”; where I put this information?<u></u><u></u></span></p>

<p class="MsoNormal"><span lang="EN-US"><u></u></span></p></div></div></blockquote><div><br>I have only quickly reviewed your patch, so this remark may be void.<br>if part of your work was derived from another driver, even parts, you have to mention it.<br>
I had the feeling that some parts were extracted from blazer* drivers...<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div link="blue" vlink="purple" lang="IT">
<div><p class="MsoNormal"><span lang="EN-US"></span></p><p class="MsoNormal"><span lang="EN-US">And what means “other part of headers”?<u></u><u></u></span></p></div></div></blockquote><div><br>I was probably referring to riello.h that misses all the standard comment header.<br>
<br>From there, you should post a patch (svn diff) of your work, so that we can all review and comment it.<br><br>cheers,<br>Arnaud<br></div></div>-- <br>Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org" target="_blank">http://www.networkupstools.org</a><br>
Debian Developer - <a href="http://www.debian.org" target="_blank">http://www.debian.org</a><br>
Free Software Developer - <a href="http://arnaud.quette.fr" target="_blank">http://arnaud.quette.fr</a><br><br>