<HTML xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<HEAD><!-- Template generated by Exclaimer Mail Disclaimers on 07:22:42 Friday, 9 November 2012 -->
<STYLE type=text/css>P.58b6aaff-49cf-4951-923f-37c7fb655c87 {
MARGIN: 0cm 0cm 0pt
}
LI.58b6aaff-49cf-4951-923f-37c7fb655c87 {
MARGIN: 0cm 0cm 0pt
}
DIV.58b6aaff-49cf-4951-923f-37c7fb655c87 {
MARGIN: 0cm 0cm 0pt
}
TABLE.58b6aaff-49cf-4951-923f-37c7fb655c87Table {
MARGIN: 0cm 0cm 0pt
}
DIV.Section1 {
page: Section1
}
</STYLE>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="Generator" content="Microsoft Word 14 (filtered medium)" />
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</HEAD>
<BODY lang="EN-GB" link="blue" vlink="purple">
<P class=58b6aaff-49cf-4951-923f-37c7fb655c87>
<div class="WordSection1">
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">please note that revisions 3771 and 3772 conclude nut_clock_*<br />
development (including UTs):<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><br />
my conclusion was that nut_clock devs were completed with 3772, and only the QRT side was remaining.<br />
but that last requires:<br />
1) that I provide you with a procedure to setup QRT (and this requires me to push a fix upstream to Ubuntu)<br />
2) that we have a jail mechanism to execute QRT, including system clock changes to not impact negatively the buildbot system.<br />
<br />
<span style=color:#1F497D><o:p></o:p></span></p>
<p class="MsoNormal"><span style=font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D>Right; I forgot to mention these tests; they are not covered by the commits,<o:p></o:p></span></p>
<p class="MsoNormal"><span style=font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D>of course.<o:p></o:p></span></p>
<p class="MsoNormal"><span style=font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D><o:p> </o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Please review the code.<br />
Note the RTC UT on Solaris; it uses perl -e 'print time;' as the external<br />
RTC authority, because date +%s is not implemented on Solaris :-(<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal" style=margin-bottom:12.0pt><br />
yep, that was my only question from a preliminary review ;)<br />
but I recall, in the meantime, the solaris situation: either gnu date (coreutils) or "perl print" to get "%s"...<br />
<br />
I've installed gnu coreutils, including date. It's available in /usr/local/bin.<br />
I've also modified the buildslave init script to first use this directory.<br />
thus, you should now be able to use the same "time authority" everywhere...<br />
<br />
<span style=color:#1F497D><o:p></o:p></span></p>
<p class="MsoNormal" style=margin-bottom:12.0pt><span style=font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D>OK, so I’ll modify it so that it only uses Perl if date bin. desn’t<o:p></o:p></span></p>
<p class="MsoNormal" style=margin-bottom:12.0pt><span style=font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D>support the %s format string.<o:p></o:p></span></p>
<p class="MsoNormal" style=margin-bottom:12.0pt><span style=color:#1F497D><o:p> </o:p></span></p>
<p class="MsoNormal" style=margin-bottom:12.0pt><span style=color:#1F497D>vasek<o:p></o:p></span></p>
<p class="MsoNormal" style=margin-bottom:12.0pt><span style=color:#1F497D><o:p> </o:p></span></p>
<p class="MsoNormal" style=margin-bottom:12.0pt><br />
I've just forced a build on 3772 to check the new PATH...<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">We might want to discuss whether such dependency on Perl is wise<br />
on Solaris; perhaps do a (configure) detection & skip the test<br />
if Perl isn't installed...<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><br />
well, that would not be a real problem since we already have a few Perl / Python requirements for our buildslaves and developers systems. And Perl, as a dependency, is not that exotic ;)<br />
<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Any questions, comments, recommendations etc welcome, as usual.<o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal" style=margin-bottom:12.0pt><br />
I'll start the review and post back.<br />
Thanks for your hard work Vasek!<br />
<br />
cheers,<br />
Arnaud<br />
-- <br />
Linux / Unix / Opensource Engineering Expert - Eaton - <a href="http://opensource.eaton.com" target="_blank">
http://opensource.eaton.com</a><br />
Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org" target="_blank">
http://www.networkupstools.org</a><br />
Debian Developer - <a href="http://www.debian.org" target="_blank">http://www.debian.org</a><br />
Free Software Developer - <a href="http://arnaud.quette.fr" target="_blank">http://arnaud.quette.fr</a><o:p></o:p></p>
</div>
</div>
</P>
<P class=58b6aaff-49cf-4951-923f-37c7fb655c87> </P>
<P class=58b6aaff-49cf-4951-923f-37c7fb655c87>
<HR id=HR1 />
Eaton Elektrotechnika s.r.o. ~ S�dlo spolecnosti, jak je zaps�no v rejstr�ku: Kom�rovsk� 2406, Praha 9 - Horn� Pocernice, 193 00, Cesk� Republika ~ Jm�no, m�sto, kde byla spolecnost zaregistrov�na: Praha ~ Identifikacn� c�slo (ICO): 498 11 894
<P class=58b6aaff-49cf-4951-923f-37c7fb655c87>
<HR id=HR1 />
<P></P>
<P class=58b6aaff-49cf-4951-923f-37c7fb655c87> </P>
<P class=58b6aaff-49cf-4951-923f-37c7fb655c87></P></P></P></BODY>
</HTML>