<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">[Please remember to copy the list.]<div><br><div><div>On Oct 15, 2013, at 8:45 AM, eric kreuwels wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>Hi Charles</div><div> </div><div>Thanks for your answer. Good questions/suggestions. I copied both the WinUPSC and the installer project on my GDRIVE and shared it with you:</div><div><a href="https://docs.google.com/file/d/0B0mSjYYj84-6ZGM4MWZfMnFxbUU/edit?usp=sharing">https://docs.google.com/file/d/0B0mSjYYj84-6ZGM4MWZfMnFxbUU/edit?usp=sharing</a></div>
<div> </div><div>Archiving WinUPSC in the NUT GitHub would be my preference. Delivery as part of te Windows distribution is basically a separate decision for you guys.</div><div> </div><div>Steps I have in mind:</div><ul>
<li>Check how WinUPSC will is perceived by the other developers! Then decide to setup a project in NUT GitHub</li><li>Maybe a good idea to have a code review: </li><ul><li>Especially how I modified the UPSC code for polling. For example how standardized is the parameter list? I made assumptions here.</li></ul></ul></div></blockquote><div>I haven't diffed your code against either NUT or WinNUT, but after a quick check, I'm not sure I understand your question here. If you are referring to the UPS variables, there is no guarantee that a specific variable will be available (except "ups.status"; think of a contact-closure UPS which can only report OL/OB/LB).</div><div><br></div><div>As an aside, in upsc.c, you use sprintf() with strlen(). There is a snprintfcat() utility in common/common.c</div><blockquote type="cite"><div dir="ltr"><ul><ul>
<li>I tried not to violate any licence and only re-use freeware, but don't fully comprehend these licences. Can these licences collide? </li></ul></ul></div></blockquote><div>They can, potentially. The one thing I spot-checked was the icon page, and I didn't see any license information there.</div><blockquote type="cite"><div dir="ltr"><ul><ul><li>Are the credentials in the about box and the manual are sufficient :-)</li></ul></ul></div></blockquote><div>I'm not sure where the About box is defined. The manual looks okay, although I wonder if the app code falls under the blanket "all rights reserved" clause: <a href="http://www.codeproject.com/info/TermsOfUse.aspx">http://www.codeproject.com/info/TermsOfUse.aspx</a></div><div><br></div><div>It probably comes down to whether this code is boilerplate for all win32 applications with an icon. I'm not the right person to make that call.</div><blockquote type="cite"><div dir="ltr"><ul><ul>
</ul><li>Fix blocking issues for a first launch. My testing setup is limited (I only have Eaton UPSes). Feedback from others is really needed.</li></ul></div></blockquote><div>One way to test your code is to use the dummy-ups driver with the sample data files provided. data/evolution500.seq simulates an MGE/Eaton Evolution 500 going on battery, then to low battery, then back online.</div><div><br></div><div>Of course, feel free to solicit testers with actual hardware. But with dummy-ups, you can basically simulate various combinations of variables, and there are many different examples in the list archives (search for "HCL"). Here's more information on dummy-ups: <a href="http://www.networkupstools.org/docs/man/dummy-ups.html">http://www.networkupstools.org/docs/man/dummy-ups.html</a></div><blockquote type="cite"><div dir="ltr"><ul><li>Code cleanup; I like the idead to reference original NUT code (remove the duplicates in my project. I re-used the ported NUT files from WinNUT)</li>
</ul></div></blockquote><div dir="ltr"><div>I CC'd Frederic Bohe who worked on the NUT windows_port branch. Perhaps he has some suggestions. The windows_port in his GitHub repo is different than the original one we converted from SVN, so I don't know the current status of that porting effort.</div><div><br></div></div><blockquote type="cite"><div dir="ltr"><div>Looking forward to work with the development team</div><div> </div><div>Eric Kreuwels</div></div></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div>-- </div><div>Charles Lepple</div><div>clepple@gmail</div><div><br></div></span><br class="Apple-interchange-newline">
</div>
<br></div></body></html>