<div dir="ltr">Hi Charles<br><div class="gmail_extra"><br><div class="gmail_quote">2017-06-07 3:42 GMT+02:00 Charles Lepple <span dir="ltr"><<a href="mailto:clepple@gmail.com" target="_blank">clepple@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Not to pick on anyone in particular, but for the sake of organization, I think we might need to address the need for variables beyond the standard ones defined here:<br>
<br>
  <a href="http://networkupstools.org/docs/developer-guide.chunked/apas01.html" rel="noreferrer" target="_blank">http://networkupstools.org/<wbr>docs/developer-guide.chunked/<wbr>apas01.html</a><br>
<br>
>From <a href="http://networkupstools.org/docs/developer-guide.chunked/ar01s04.html#_variable_names" rel="noreferrer" target="_blank">http://networkupstools.org/<wbr>docs/developer-guide.chunked/<wbr>ar01s04.html#_variable_names</a> :<br>
<br>
"PLEASE don’t make up new variables and commands just because you can. The new dstate functions give us the power to create just about anything, but that is a privilege and not a right. Imagine the mess that would happen if every developer decided on their own way to represent a common status element."<br>
<br>
On the other hand, it is useful to expose everything that comes out of the stub driver generator to see if it is useful. And for the UPSes where we don't have good documentation, well... I'm guilty of this, too:<br>
<br>
  <a href="https://github.com/networkupstools/nut/blob/master/drivers/tripplite_usb.c#L613" rel="noreferrer" target="_blank">https://github.com/<wbr>networkupstools/nut/blob/<wbr>master/drivers/tripplite_usb.<wbr>c#L613</a><br>
<br>
Any thoughts? Does "ups.debug.*" work? Just "debug.*"? "vendor.XYZ.*"?<br></blockquote><div>Â <br></div><div>2nded!<br><br></div><div>there are 2 different use cases here:<br></div><div>- <a href="http://vendor.xyz">vendor.xyz</a> would be valid for specific vendor things in production.<br>however, our approach is that any such things can have a name useful for others too.<br></div><div>so that would probably limit that point to "opaque" features (I once talked or at least though of using a <a href="http://vendor.xyz">vendor.xyz</a> collection to access the ups internals...)<br></div><div>* ups.debug (or preferably <a href="http://debug.xyz">debug.xyz</a>) can be transiently useful to get visibility on data (through upsc dumps) to finalize a new driver development or further evolution. That could even be used in conjunction with a driver generic flag (or maybe -D) to enable or trim out these<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Here are the two pull requests that prompted this email:<br>
<br>
 * <a href="https://github.com/networkupstools/nut/pull/431" rel="noreferrer" target="_blank">https://github.com/<wbr>networkupstools/nut/pull/431</a><br>
 * <a href="https://github.com/networkupstools/nut/pull/440" rel="noreferrer" target="_blank">https://github.com/<wbr>networkupstools/nut/pull/440</a><br></blockquote></div><br></div><div class="gmail_extra">not looked at these thoroughly yet, but #431 tends to expose raw HID data as nut data.<br>I'm not in favor of these! Most of these HID data are either used in other HID subdrivers (thus, references available) or to be considered for dropping or for the <a href="http://debug.xyz">debug.xyz</a> collection...<br><br></div><div class="gmail_extra">cheers,<br clear="all"></div><div class="gmail_extra">Arno<br></div><div class="gmail_extra">-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Eaton Data Center Automation Solutions - Opensource Leader - <a href="http://42ity.org" target="_blank">http://42ity.org</a><br>NUT (Network UPS Tools) Project Leader - <a href="http://www.networkupstools.org" target="_blank">http://www.networkupstools.org</a><br>Debian Developer - <a href="http://www.debian.org" target="_blank">http://www.debian.org</a><br>Free Software Developer - <a href="http://arnaud.quette.fr" target="_blank">http://arnaud.quette.fr</a><br></div>
</div></div>