<br><br><div class="gmail_quote">2011/3/17 Arjen de Korte <span dir="ltr"><<a href="mailto:nut%2Busers@de-korte.org">nut+users@de-korte.org</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Citeren Charles Lepple <<a href="mailto:clepple@gmail.com" target="_blank">clepple@gmail.com</a>>:<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Arjen: do we actually have any cases of reports larger than 8 bytes?<br>
</blockquote>
<br></div>
Yes. At least the MGE Evolution series uses reports that are larger than 8 bytes.</blockquote><div><br>some Eaton and Dell models too<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
If so, should we mark this as a quirk for CyberPower devices?<br>
</blockquote>
<br></div>
Well, I still don't understand why we can't read with an arbitrary buffer length in the libusb call in the first place. This should be handled by the library (not the application).<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Also, it<br>
seems like we need to distinguish between returning 0 and <0 from the<br>
libusb call. Currently, we are reading errno when a zero-length packet<br>
is being read.<br>
</blockquote>
<br></div>
This too is broken. If we attempt to read a report and libusb can't return any data, it should at least give us a hint why. I really feel that this should be handled by the library, not NUT.<br></blockquote><div><br>
seconded. I've not had a look at libusb-1 to see if the situation has improved, but I hope so...<br><br>cheers,<br>Arnaud<br></div></div>-- <br>Linux / Unix Expert R&D - Eaton - <a href="http://powerquality.eaton.com" target="_blank">http://powerquality.eaton.com</a><br>
Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org/" target="_blank">http://www.networkupstools.org/</a><br>Debian Developer - <a href="http://www.debian.org" target="_blank">http://www.debian.org</a><br>
Free Software Developer - <a href="http://arnaud.quette.free.fr/" target="_blank">http://arnaud.quette.free.fr/</a><br><br>