[Openstack-devel] Bug#687311: Bug#687311: Bug#687311: Bug#687311: Diff for keystone 2012.1.1-7, trying to fix RC bug #687311

[YunQiang Su]

Two questions about postinst:

1.  if [ $RET = "sqlite3" ]
	then
	    dbc_name="keystone.sqlite"
	    db_set keystone/db/dbname $dbc_name
	fi
  If user modified /etc/keystone.conf manually to change the path of
sqlite database file,
  while this paragraph will change it to the default.
  I believe here, we should keep the one in /etc/keystone.conf.

2. if [ "$dbc_dbtype" = "mysql" ] || [ "$dbc_dbtype" = "pgsql" ] ; then
	        [ -n "$dbc_dbport" ] && dbport=:$dbc_dbport
	        SQL_CONNECTION="$dbc_dbtype://$dbc_dbuser:$dbc_dbpass@${dbc_dbserver:-localhost}$dbport/$dbc_dbname"
	    else
	        SQL_CONNECTION="sqlite:///$dbc_basepath/$dbc_dbname"
   fi

  The problem similar with above one, if user changed the line
"connection=" to mssql or oracle or db2 etc,
  this will override the users config.
  Maybe, now dbc or something else cannot support msssql, oracle or
db2 etc, but this is still a bad idea to
  override the users config.

On Mon, Sep 17, 2012 at 9:50 PM, Thomas Goirand <thomas at goirand.fr> wrote:
> Attached is the diff fix for this bug.
>
> Thomas
>
> _______________________________________________
> Openstack-devel mailing list
> Openstack-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/openstack-devel
>



-- 
YunQiang Su