[Openstack-devel] Bug#659277: [RFR] templates://glance/{glance-api.templates, glance-common.templates}
Christian PERRIER
bubulle at debian.org
Mon Feb 13 06:16:37 UTC 2012
Specific note: I do not understand anything about this
package. debian/control doesn't help and I'm not online for doing
specific research.
I'm afraid this is a perfect example of a package that has description
problems and where the description should be completed with something
aimed at giving someone finding this package randomly a small idea of
what it is about.
I'll put comments inline.
Please find, for review, the debconf templates and packages descriptions for the glance source package.
This review will last from Monday, February 13, 2012 to Thursday, February 23, 2012.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.
Rationale:
--- glance.old/debian/glance-common.templates 2012-02-09 19:37:27.698580451 +0100
+++ glance/debian/glance-common.templates 2012-02-13 07:07:12.885740492 +0100
@@ -4,5 +4,5 @@
Default: caching
_Description: Pipeline flavor:
If you use the OpenStack Identity Service (Keystone), you might want to
- select keystone. If you don't use this service, you can safely choose
- caching only.
\ No newline at end of file
+ select "keystone". If you don't use this service, you can safely choose
+ "caching" only.
Simply use quotes around choices. I would propose making the choices
translatable but they seem to be jargon related to the "thing"
(OpenStack blahblah) and making them translatable will just bring
trouble to translators....
--- glance.old/debian/control 2012-02-09 19:37:27.702580564 +0100
+++ glance/debian/control 2012-02-13 07:08:39.090894308 +0100
@@ -41,7 +41,7 @@
python-xattr,
python-crypto,
python-httplib2 (>= 0.6.0)
-Description: OpenStack Image Registry and Delivery Service - Python client library
+Description: OpenStack image registry and delivery service - Python client library
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
@@ -62,7 +62,7 @@
python-sqlalchemy-ext | python-sqlalchemy (<< 0.6.3-2),
python-xattr,
python-paste
-Description: OpenStack Image Registry and Delivery Service - Common
+Description: OpenStack image registry and delivery service - Common
Just stop using capitals everywhere. This is my only proposed change
because I don't understand a s*** about the remaining of the package
description.
What is OpenStack?
What "image" are we talking about? Is this about a place where to
store my holiday and family pictures? It doesn't seem to be this but
nothing give a clue about what we're talking about.
Who is Nova?
What is an object store (a place where I can buy objects such as screwdrivers?)?
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
.../...
No other changes proposed until I understand something about what this
package is about..:-)
There are a few other spelling things like "stand-along" that probably
deserve being corrected, though.
-------------- next part --------------
Template: glance-api/auth-url
Type: string
Default: http://localhost:5000
_Description: Auth server URL:
Type the URL of your auth server. This is typically the URL of your
OpenStack Identity Service (Keystone).
Template: glance-api/auth-token
Type: string
_Description: Auth server admin token:
-------------- next part --------------
Template: glance/paste-flavor
Type: select
Choices: keystone, caching, keystone+caching, cachemanagement, keystone+cachemanagement
Default: caching
_Description: Pipeline flavor:
If you use the OpenStack Identity Service (Keystone), you might want to
select "keystone". If you don't use this service, you can safely choose
"caching" only.
-------------- next part --------------
--- glance.old/debian/glance-common.templates 2012-02-09 19:37:27.698580451 +0100
+++ glance/debian/glance-common.templates 2012-02-13 07:07:12.885740492 +0100
@@ -4,5 +4,5 @@
Default: caching
_Description: Pipeline flavor:
If you use the OpenStack Identity Service (Keystone), you might want to
- select keystone. If you don't use this service, you can safely choose
- caching only.
\ No newline at end of file
+ select "keystone". If you don't use this service, you can safely choose
+ "caching" only.
--- glance.old/debian/control 2012-02-09 19:37:27.702580564 +0100
+++ glance/debian/control 2012-02-13 07:08:39.090894308 +0100
@@ -41,7 +41,7 @@
python-xattr,
python-crypto,
python-httplib2 (>= 0.6.0)
-Description: OpenStack Image Registry and Delivery Service - Python client library
+Description: OpenStack image registry and delivery service - Python client library
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
@@ -62,7 +62,7 @@
python-sqlalchemy-ext | python-sqlalchemy (<< 0.6.3-2),
python-xattr,
python-paste
-Description: OpenStack Image Registry and Delivery Service - Common
+Description: OpenStack image registry and delivery service - Common
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
@@ -75,7 +75,7 @@
Section: python
Replaces: glance (<< 2012.1~e2-3)
Depends: ${python:Depends}, ${misc:Depends}, glance-common (= ${source:Version}), debconf
-Description: OpenStack Image Registry and Delivery Service - API
+Description: OpenStack image registry and delivery service - API
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
@@ -88,7 +88,7 @@
Section: python
Replaces: glance (<< 2012.1~e2-3)
Depends: ${python:Depends}, ${misc:Depends}, glance-common (= ${source:Version})
-Description: OpenStack Image Registry and Delivery Service - Registry
+Description: OpenStack image registry and delivery service - Registry
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
@@ -101,7 +101,7 @@
Section: python
Depends: glance-api (= ${source:Version}), glance-registry (= ${source:Version}),
${misc:Depends}
-Description: OpenStack Image Registry and Delivery Service
+Description: OpenStack image registry and delivery service
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
@@ -113,7 +113,7 @@
Architecture: all
Section: doc
Depends: libjs-jquery, libjs-underscore, ${misc:Depends}
-Description: OpenStack Image Registry and Delivery Service - Documentation
+Description: OpenStack image registry and delivery service - Documentation
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
-------------- next part --------------
Source: glance
Section: net
Priority: extra
Maintainer: PKG OpenStack <openstack-devel at lists.alioth.debian.org>
Uploaders: Julien Danjou <acid at debian.org>,
Thomas Goirand <zigo at debian.org>,
Ghe Rivero <ghe at debian.org>
Build-Depends: debhelper (>= 7.0.50),
python-all (>= 2.6.6-3~),
po-debconf
Build-Depends-Indep:
python-setuptools,
python-sphinx,
python-distutils-extra,
python-sqlalchemy-ext | python-sqlalchemy (<< 0.6.3-2),
python-nose,
python-webob,
python-migrate,
python-routes,
python-boto,
python-kombu,
python-httplib2 (>= 0.6.0)
Standards-Version: 3.9.2
Homepage: http://launchpad.net/glance
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=openstack/glance.git;a=summary
Vcs-Git: git://anonscm.debian.org/openstack/glance.git
Package: python-glance
Architecture: all
Section: python
Depends: ${python:Depends}, ${misc:Depends},
python-webob,
python-routes,
python-daemon,
python-eventlet,
python-sqlalchemy-ext | python-sqlalchemy (<< 0.6.3-2),
python-pastedeploy,
python-argparse,
python-migrate,
python-kombu,
python-xattr,
python-crypto,
python-httplib2 (>= 0.6.0)
Description: OpenStack image registry and delivery service - Python client library
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
OpenStack's Swift service, to Nova's compute nodes.
.
This package contains the Python client libraries.
Package: glance-common
Architecture: all
Section: python
Replaces: glance (<< 2012.1~e2-3)
Depends: ${python:Depends}, ${misc:Depends},
adduser,
python-eventlet,
python-glance (= ${source:Version}),
python-migrate,
python-routes,
python-sqlalchemy-ext | python-sqlalchemy (<< 0.6.3-2),
python-xattr,
python-paste
Description: OpenStack image registry and delivery service - Common
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
OpenStack's Swift service, to Nova's compute nodes.
.
This package contains the glance common.
Package: glance-api
Architecture: all
Section: python
Replaces: glance (<< 2012.1~e2-3)
Depends: ${python:Depends}, ${misc:Depends}, glance-common (= ${source:Version}), debconf
Description: OpenStack image registry and delivery service - API
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
OpenStack's Swift service, to Nova's compute nodes.
.
This package contains the glance api server.
Package: glance-registry
Architecture: all
Section: python
Replaces: glance (<< 2012.1~e2-3)
Depends: ${python:Depends}, ${misc:Depends}, glance-common (= ${source:Version})
Description: OpenStack image registry and delivery service - Registry
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
OpenStack's Swift service, to Nova's compute nodes.
.
This package contains the glance registry server.
Package: glance
Architecture: all
Section: python
Depends: glance-api (= ${source:Version}), glance-registry (= ${source:Version}),
${misc:Depends}
Description: OpenStack image registry and delivery service
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
OpenStack's Swift service, to Nova's compute nodes.
.
This is a dependency package.
Package: python-glance-doc
Architecture: all
Section: doc
Depends: libjs-jquery, libjs-underscore, ${misc:Depends}
Description: OpenStack image registry and delivery service - Documentation
The Glance project provides an image registration, discovery and
delivery service. These services may be used as stand-along services, and
they may also be used by Nova to deliver images from object stores, such as
OpenStack's Swift service, to Nova's compute nodes.
.
This package contains the documentation.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/openstack-devel/attachments/20120213/96ef4df6/attachment.pgp>
More information about the Openstack-devel
mailing list