<div dir="ltr">Hey Thomas,<br><br>On Wed, May 13, 2015 at 3:18 AM, Thomas Goirand <<a href="mailto:thomas@goirand.fr" target="_blank">thomas@goirand.fr</a>> wrote:<br>> My hint here is to try to do:<br>><br>> python -c "import manila.tests.share.drivers.netapp.dataontap.client.test_client_cmode"<br>><br>> and see what's the error. I did that, and could see:<br>><br>> ImportError: No module named lxml<br>><br>> Result: please add python-lxml as build-depends-indep.<br>><div><br></div><div>As Andreas mentioned before, lxml is added to the control file. I did what you proposed and the output is:</div><div><br></div><div><font size="1">$<b style="line-height:100%"><font face="monospace, monospace">ython
-c "import
manila.tests.share.drivers.netapp.dataontap.client.test_client_cmode"</font></b></font></div>
<p class="" style="margin-bottom:0in">
<font face="monospace, monospace" size="1"><font color="#222222"><font>Traceback
(most recent call last): </font></font>
</font></p>
<p class="" style="margin-bottom:0in">
<font face="monospace, monospace" size="1"><font color="#222222"> <font>File
"<string>", line 1, in <module> </font></font>
</font></p>
<p class="" style="margin-bottom:0in">
<font face="monospace, monospace"><font color="#222222"><font size="1"> </font><font><font size="1">File
"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py",
line 33, in <module> </font></font></font><font size="1">
</font></font></p>
<p class="" style="margin-bottom:0in">
<font face="monospace, monospace" size="1"><font color="#222222"> <font>class
NetAppClientCmodeTestCase(test.TestCase): </font></font>
</font></p>
<p class="" style="margin-bottom:0in">
<font face="monospace, monospace"><font color="#222222"><font size="1"> </font><font><font size="1">File
"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py",
line 1710, in NetAppClientCmodeTestCase </font></font></font><font size="1">
</font></font></p>
<p class="" style="margin-bottom:0in">
<font face="monospace, monospace" size="1"><font color="#222222"> <font>@ddt.unpack
</font></font>
</font></p>
<p class="" style="margin-bottom:0in">
<font color="#222222"><font face="monospace, monospace" size="1">AttributeError:
'module' object has no attribute 'unpack' </font></font>
</p>
<p class="" style="margin-bottom:0in"><br></p><p class="" style="margin-bottom:0in">As you can see, some thing is wrong with ddt.unpack.
</p><p class="" style="margin-bottom:0in"><font color="#222222"><b><font face="Bitstream Charter, serif" style="font-size:10pt">$
</font><font face="monospace, monospace" size="1">python -c "import ddt"</font></b></font><font color="#222222" face="monospace, monospace" size="1">
#Done! It is ok.</font><br></p><p class="" style="margin-bottom:0in"><b style="font-family:monospace,monospace;font-size:x-small">$
python -c "import ddt.unpack"</b></p><p class="" style="margin-bottom:0in;font-variant:normal;font-style:normal;font-weight:normal">
<font face="monospace, monospace" size="1"><font color="#222222"><font>Traceback
(most recent call last): </font></font>
</font></p><p class="" style="margin-bottom:0in;font-variant:normal;font-style:normal;font-weight:normal">
<font face="monospace, monospace" size="1"><font color="#222222"> <font>File
"<string>", line 1, in <module> </font></font>
</font></p><p class="" style="margin-bottom:0in">
</p><p class="" style="margin-bottom:0in">
<font color="#222222"><font face="monospace, monospace" size="1">ImportError:
No module named unpack</font></font></p><p class="" style="margin-bottom:0in"><font color="#222222"><font face="Bitstream Charter, serif"><font style="font-size:10pt">As mentioned in DDT documentations, unpack is one of ddt modules and so importing ddt.unpack should not faced with an error.</font></font></font></p><p class="" style="margin-bottom:0in"><font color="#222222"><font face="Bitstream Charter, serif"><font style="font-size:10pt">I noticed that you are the maintainer of python-ddt package. Therefore I thought the best approach for solving the problem is asking from you :)</font></font></font></p><div><br>> BTW, please do run pkgos-reqsdiff, it will show lots of issues. Note that you need to run pkgos-fetch-fake-repo so that pkgos-reqsdiff can use madison-lite using the versions in Jessie, otherwise it wont be able to report versions correctly.</div><div><br></div><div>I did pkgos-reqsdiff and pushed it on git, when you introduced this tool. But all of the efforts were done without pkgos-fetch-fake-repo. So, i re-ran this command. </div><div>When I use pkgos-fetch-fake-repo it warns about some version numbers which should be removed or added to the control file. The output of 'pkgos-reqsdiff' is some thing like (The verbose version of output is attached):<br></div><div><font face="monospace, monospace" size="1"><br></font></div><div><div><font face="monospace, monospace" size="1">--- /tmp/pkgos-reqsdiff1.woz5Jz 2015-05-23 17:43:43.531307483 +0000</font></div><div><font face="monospace, monospace" size="1">+++ /tmp/pkgos-reqsdiff1.NdtQVi 2015-05-23 17:43:54.943269331 +0000</font></div><div><font face="monospace, monospace" size="1">@@ -3,9 +3,9 @@</font></div><div><font face="monospace, monospace" size="1"> dh-systemd,</font></div><div><font face="monospace, monospace" size="1"> openstack-pkg-tools (>= 23~),</font></div><div><font face="monospace, monospace" size="1"> po-debconf,</font></div><div><font face="monospace, monospace" size="1">- python-all,</font></div><div><font face="monospace, monospace" size="1">+ python-all (>= 2.6.6-3~),</font></div><div><span style="font-family:monospace,monospace;font-size:x-small">@@ -25,15 +25,15 @@</span><br></div><div><font face="monospace, monospace" size="1"> python-netaddr,</font></div><div><font face="monospace, monospace" size="1"> python-neutronclient (>= 2.3.11),</font></div><div><font face="monospace, monospace" size="1"> python-novaclient (>= 2:2.22.0),</font></div><div><font face="monospace, monospace" size="1">- python-oslo.concurrency,</font></div><div><font face="monospace, monospace" size="1">+ python-oslo.concurrency (>= 1.8.0),</font></div><div><font face="monospace, monospace" size="1"> python-oslo.config (>= 1:1.9.3),</font></div></div><div><br></div><div>After applying these changes and adding version numbers, I ran 'cme fix dpkg-control' and the result is some thing like this:</div><div><br></div><div><span style="font-family:monospace,monospace;font-size:x-small">mali@buildEnv:/home/mali/manila$
</span><b style="font-family:monospace,monospace;font-size:x-small">cme fix dpkg-control</b><br></div><div>
<p style="margin-bottom:0in"><font face="monospace, monospace" size="1">Fixing
dpkg-control configuration...</font></p><p style="margin-bottom:0in"><span style="font-family:monospace,monospace;font-size:x-small">Reading
package lists... Done</span></p>
<p style="margin-bottom:0in"><font face="monospace, monospace" size="1">Building
dependency tree
</font></p>
<p style="margin-bottom:0in"><font face="monospace, monospace" size="1">Reading
state information... Done
</font></p>
<p style="margin-bottom:0in"><font face="monospace, monospace" size="1">Warning
in 'source Build-Depends:5' value 'python-all (>= 2.6.6-3~)':
unnecessary versioned dependency: python-all >= 2.6.6-3~. Debian
has squeeze -> 2.6.6-3+squeeze7; wheezy -> 2.7.3-4+deb7u1;
jessie-kfreebsd -> 2.7.9-1; jessie -> 2.7.9-1; stretch ->
2.7.9-1; sid -> 2.7.9-1;</font></p><p style="margin-bottom:0in">
</p><p style="margin-bottom:0in"><font><font face="monospace, monospace" size="1">Warning
in 'source Build-Depends-Indep:19' value 'python-oslo.concurrency (>=
1.8.0)': unnecessary versioned dependency: python-oslo.concurrency >=
1.8.0. Debian has jessie-backports -> 1.8.0-1~bpo8+1; stretch ->
1.8.0-1; sid -> 1.8.0-1;</font><font face="Bitstream Charter, serif" style="font-size:10pt"> </font></font></p><p style="margin-bottom:0in"><span style="font-size:10pt;font-family:'Bitstream Charter',serif">These two tools reports two different result. </span></p><p style="margin-bottom:0in"><span style="font-size:10pt;font-family:'Bitstream Charter',serif">I personally believe cme report is correct, because I checked the version numbers in stable/testing/unstable repo (at least for 3-4 of the packages), and the cme output about version numbers was completely true. Maybe we need to some little changes in '</span>pkgos-reqsdiff'.<span style="font-family:'Bitstream Charter',serif;font-size:10pt"> Or we can just recommend to do a 'cme fix dpk-control' after running 'wrap-and-sort -t -a', '</span>pkgos-fetch-fake-repo', and 'pkgos-reqsdiff'.</p></div><div><br></div><div>><br>> If you didn't get it, pkgos-reqsdiff does a diff between the dependency parts which is in your debian/control (try to use pkgos-show-control-depends), and what it calculates using the requirements.txt and tests-requirements.txt (try pkgos-parse-requirements).<br>><br>> The part on top (the Build-Depends:) is nearly always the same, so it's calculated using some static heuristics, like: does the package has debconf templates? Does it has python3 support? Stuff like that...<br>><br>> Again, this isn't a magic tool, but a helper for you, as a package maintainer, to use and check if you didn't forget anything. For example here, it wouldn't have show you the missing python-lxml Build-Depends-Indep:, as upstream didn't declare it at all.<br>><br>> I hope this helps...<br>></div><div>Thanks for explanation :)</div><div><br></div><div>Best regards,</div><div>Mali</div><div><br></div><div><br>> Cheers,<br>><br>> Thomas Goirand (zigo)<br>><br>><br>> _______________________________________________<br>> Openstack-devel mailing list<br>> <a href="mailto:Openstack-devel@lists.alioth.debian.org" target="_blank">Openstack-devel@lists.alioth.debian.org</a><br>> <a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/openstack-devel" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/openstack-devel</a><br><br><br><br><br>--<br>------------<br>you can't start the next chapter if you keep re-reading the last one<br><br>mali<br><div class="gmail_extra">
</div></div></div>