[Oval-commits] r253 - trunk/oval-server/debian

[Javier Fernandez-Sanguino Pen~a]

Author: jfs
Date: 2007-09-04 21:59:28 +0000 (Tue, 04 Sep 2007)
New Revision: 253

Modified:
   trunk/oval-server/debian/postrm
Log:
Added the same comments as to oval-agent

Modified: trunk/oval-server/debian/postrm
===================================================================
--- trunk/oval-server/debian/postrm	2007-09-04 21:58:28 UTC (rev 252)
+++ trunk/oval-server/debian/postrm	2007-09-04 21:59:28 UTC (rev 253)
@@ -19,6 +19,7 @@
 # the debian-policy package
 
 
+# (jfs) BUG: Dpkg should not be invoked from within a postrm script
 OVALAGENT=`dpkg -l | grep oval-agent | awk '{print $1}'`
 
 case "$1" in
@@ -28,12 +29,18 @@
     ;;
 
     remove)
+        # (jfs) BUG: No need to remove the directory, dpkg will
+        # remove it if empty, just remove the log file...
 	if [ "$OVALAGENT" != "ii" ]; then
 		rm -rf /var/log/oval
 	else
 		rm -rf /var/log/oval/oval-server.log
 	fi
 	
+        # (jfs) BUG: This check should be more strict, this user
+        # might have been created by the user but not by the package
+        # also, it makes more sense to have an oval-agent and oval-server
+        # users so that they do not overlap
 	if [ "$OVALAGENT" != "ii" ]; then
 		if id oval >/dev/null; then
 			deluser oval