2007/7/25, Javier Fernández-Sanguino Peña <<a href="mailto:jfs@computer.org">jfs@computer.org</a>>:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Thu, Jul 19, 2007 at 07:40:39PM +0000, Pavel Vinogradov wrote:<br>> - bool GetSubsrtings(string lineFromFile, ObjectEntity* line, StringVector* substrings);<br>> + bool GetSubstrings(string lineFromFile, ObjectEntity* line, StringVector* substrings);
<br>Are you sure this is right? Looks like a typo to me.</blockquote><div><br> </div><div> I think that this change is valid. I have two arguments for this:<br>1. function name 'GetSubsrtings' - don't have any correct sense for this context, when GetSubstrings - seems fine
<br>2. Original version of source file TextFileContentProbe.cpp (<a href="http://svn.debian.org/wsvn/oval/trunk/Interpreters/src/probes/independent/TextFileContentProbe.cpp?op=file&rev=90&sc=1">http://svn.debian.org/wsvn/oval/trunk/Interpreters/src/probes/independent/TextFileContentProbe.cpp?op=file&rev=90&sc=1
</a>) contain comment in GetLines function:<br><br>//read the file line by line<br>//call GetSubstrings method<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On the other hand. This implemenation is removing the current implementation<br>of the TextFileProbe class from the reference interpreter with no new code<br>being included. Why?</blockquote></div> I don't understand you. I rename GetSubsrtings function to GetSubstrings and use GetSubstrings in GetLines member of TextFileContentProbe.
<br><br>-- <br>Pavel Vinogradov<br>NixDev Linux Developer