[parted-devel] [PATCH] detect device map type

[Jim Meyering]

Guido Günther <agx at sigxcpu.org> wrote:

> On Sun, May 11, 2008 at 07:14:14PM +0200, Jim Meyering wrote:
>> Sure.
>> Parted already has root-only tests; "grep privileges_required_ tests/*".
>> For portable losetup-using tests, see lvm's tests/.  If you prefer,
>> just write a few stand-alone sequences of commands that exercise the
>> new code and clean up afterward, and I'll convert them into test scripts.
> O.k., seems I overlooked this. Attached are some basic tests as you
> suggested I took some of the code from dmsetup.
>
>> > Can we apply the patch in the meantime?
>>
>> We'll have to wait for copyright paperwork to go through, so please
>> start that process ASAP.  It usually takes a couple weeks.

Hi Guido,

I'm looking through your patches.
Running the new test as root elicits a failure for me,
so I'm investigating that.  Looking at the file you added,
dm-utils.sh, it seems to come from lvm's tests/lvm-utils.sh, but
with some changes.  Or maybe you took an older version, verbatim?
If you made changes, please list them with an explanation of why
you made them.  Otherwise, I'll use the latest from lvm's CVS repository.

By the way, normally, facts like that would be noted in
a commit log/ChangeLog entry something like this:

  * tests/dm-utils.sh: New file.  Copied from lvm's tests/lvm-utils.sh.

Thanks for contributing,

Jim