[PATCH 3/3] tests: disable the taint-distcheck rule

Jim Meyering meyering at redhat.com
Thu Jul 9 17:36:46 UTC 2009


* dist-check.mk (taint-distcheck): Disable rule, since it
would trigger a bug in libtool-generated scripts.
---
 dist-check.mk |   25 ++++---------------------
 1 files changed, 4 insertions(+), 21 deletions(-)

diff --git a/dist-check.mk b/dist-check.mk
index 40e909c..0f20af2 100644
--- a/dist-check.mk
+++ b/dist-check.mk
@@ -17,28 +17,11 @@ t_prefix = $(tp)/a
 t_taint = '$(t_prefix) b'
 fake_home = $(tp)/home

-# Ensure that tests run from tainted build and src dir names work,
-# and don't affect anything in $HOME.  Create witness files in $HOME,
-# record their attributes, and build/test.  Then ensure that the
-# witnesses were not affected.
+# Disable this test, since libtool-generated scripts
+# can't deal with a space-tainted srcdir.
 ALL_RECURSIVE_TARGETS += taint-distcheck
-taint-distcheck: $(DIST_ARCHIVES)
-	test -d $(t_taint) && chmod -R 700 $(t_taint) || :
-	-rm -rf $(t_taint) $(fake_home)
-	mkdir -p $(t_prefix) $(t_taint) $(fake_home)
-	GZIP=$(GZIP_ENV) $(AMTAR) -C $(t_taint) -zxf $(distdir).tar.gz
-	mkfifo $(fake_home)/fifo
-	touch $(fake_home)/f
-	mkdir -p $(fake_home)/d/e
-	ls -lR $(fake_home) $(t_prefix) > $(tp)/.ls-before
-	cd $(t_taint)/$(distdir)			\
-	  && ./configure				\
-	  && $(MAKE)					\
-	  && HOME=$(fake_home) $(MAKE) check		\
-	  && ls -lR $(fake_home) $(t_prefix) > $(tp)/.ls-after \
-	  && diff $(tp)/.ls-before $(tp)/.ls-after	\
-	  && test -d $(t_prefix)
-	rm -rf $(tp)
+.PHONY: taint-distcheck
+taint-distcheck:

 # Verify that a twisted use of --program-transform-name=PROGRAM works.
 define install-transform-check
--
1.6.3.3.524.g8586b



More information about the parted-devel mailing list