[parted-devel] gpt_probe(): possible bug.

rahul dev rahul_dev_agg at yahoo.co.in
Fri Jul 31 12:13:22 UTC 2009


Guys,

  gpt_probe() function doesn't check for GPT_HEADER_SIGNATURE in the backup copy of partition table if the gpt signature is not found in the primary table.

if (ped_device_read(dev, pth_raw, 1, GPT_HEADER_SECTORS)
|| ped_device_read(dev, pth_raw, dev->length - 1, GPT_HEADER_SECTORS)) {
       gpt = pth_new_from_raw (dev, pth_raw);
       if (gpt->Signature == PED_CPU_TO_LE64(GPT_HEADER_SIGNATURE))
               gpt_sig_found = 1;
}

If the signature is not found in the primary header, it doesn't check for it in the secondary header.

Is this a bug ?

Shouldn't we check for the gpt signature in the backup header in case it is not foung in the primary header?

thanks,
rahul


      Yahoo! recommends that you upgrade to the new and safer Internet Explorer 8. http://downloads.yahoo.com/in/internetexplorer/




More information about the parted-devel mailing list