[parted-devel] Parted Stuff that needs fixing before 1.8.9

[Joel Granados]

On Thu, Jun 04, 2009 at 05:16:51PM +0200, Gilles Espinasse wrote:
> 
> ----- "Joel Granados" <jgranado at redhat.com> a écrit :
> 
> > > > 
> > > > Scratch that.  I think 7 should not go in.  That addition to the
> > > > documentation is unnecessary.  The docs already say that primary,
> > > > logical and extended are _only_ supported in msdos and dhv type
> > > > partitions.  This already informs that sun labels do not support
> > > > primary.
> > > > 
> > > It is not exactly what I show, looking at
> > >
> > http://git.debian.org/?p=parted/parted.git;a=blob;f=doc/parted.texi;h=936a1f615bfcbb7380720ed7e61963d48af3f373;hb=master
> > > 
> > > @var{part-type} is one of: primary, extended, logical.  Extended
> > > and logical are only used for msdos and dvh disk labels.
> > 
> > My question here is: How does this imply that sun labels support
> > primary, extended or logical?  If it were to imply that, I would
> > think that we need a clarification. But I clearly see that it says "only
> > used for msdos and dvh disk labels.".  If this implies something, its that
> > sun labels are not to use primary, logical or extended.
> > 
> > Can you pls expand on your resoning...
> > 
> Just change so
> @var{part-type} is one of: primary, extended, logical.  Primary, extended
> and logical are only used for msdos and dvh disk labels.

Aha.  I see what you are seeing...  But I still think we need to address
this in a more general way.  I have attached a patch with an initial
idea.

The difference with your approach is that we change the whole mkpart
documentation section to reflect the fact that everything except the
start and end sizes are needed in the command.  And we further specify,
per disk label, when each argument is expected.

What do you think?


> 
> Not everybody has your knowledge and know that primary, extended, logical are narrowly linked stuff.
> By saying only 'Extended and logical' are not used for msdos..., you let poor simple man as me fall into the trap.
> 
> Gilles

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.
-------------- next part --------------
diff --git a/doc/parted.texi b/doc/parted.texi
index 936a1f6..4d2237b 100644
--- a/doc/parted.texi
+++ b/doc/parted.texi
@@ -673,7 +673,7 @@ Make a @var{fat32} file system on partition 2.
 @cindex mkpart, command description
 @cindex command description, mkpart
 
- at deffn Command mkpart @var{part-type} [@var{fs-type}] @var{start} @var{end}
+ at deffn Command mkpart [@var{part-type} @var{fs-type} @var{name}] @var{start} @var{end}
 
 Creates a new partition, @emph{without} creating a new file system on
 that partition.  This is useful for creating partitions for file systems
@@ -684,8 +684,12 @@ partitions (i.e., non-extended partitions).  @var{start} and @var{end}
 are the offset from the beginning of the disk, that is, the ``distance''
 from the start of the disk.
 
- at var{part-type} is one of: primary, extended, logical.  Extended and
-logical are only used for msdos and dvh disk labels.
+ at var{part-type} is one of: primary, extended, logical.  These must be used
+with msdos and dvh disk labels.
+
+ at var{name} must be used with gpt tables.
+
+ at var{part-type} and @var{name} must not be used with sun disk lable.
 
 @var{fs-type} must be on of these supported file systems:
 @itemize @bullet