[parted-devel] [PATCH 13/14] Ignore xfs based test when mkfs.xfs is not present

Jim Meyering jim at meyering.net
Fri Jun 5 13:58:20 UTC 2009


Joel Granados Moreno wrote:
> When the mkfs.xfs command was not present the test failed because it
> could not create an xfs file system.  This resulted in a false negative.
>
> * lvm-utils.sh (fs_xfs_exists_) : New function.
> * t4100-msdos-partition-limits.sh : Ignore the whole test when mkfs.xfs
>   is not present.

This is already fixed on next:
There, I added this function to test-lib.sh:

require_xfs_()
{
  ( mkfs.xfs -V ) >/dev/null 2>&1 ||
    {
      say "skipping $0: this test requires XFS support"
      test_done
      exit
    }
}

So if you're inclined, you can see about cherry-picking
the required part(s).  If not, let me know and I'll do it.



More information about the parted-devel mailing list