[parted-devel] [PATCH 04/14] do not discard bootcode from extended partition

[Petr Uzel]

On Tue, Jun 09, 2009 at 11:06:28AM +0200, Jim Meyering wrote:
> 
> Take a look, or try to merge and then run the tests,
> including with valgrind.
> 
> There may not be an official version-control conflict,
> but that change would certainly introduce a nasty bug.
> 
> Quick answer: table is declared like this:
> 
>     DosRawTable table;
> 
> yet your added ped_device_read call may write >512 bytes
> (i.e., sector size) into that buffer, thus clobbering the stack.

So without looking into 'next' code, I assume that everything what has
to be done here is to read the sector into a temporary buffer and then
memcpy first 512B (or 440B) from that buffer to table, right?


Thanks,

-- 
Best regards / s pozdravem

Petr Uzel, Packages maintainer
---------------------------------------------------------------------
SUSE LINUX, s.r.o.                          e-mail: puzel at suse.cz
Lihovarská 1060/12                          http://www.suse.cz
190 00 Prague 9                             
Czech Republic