[parted-devel] [PATCH] libparted: remove limits on loop labels
jim at meyering.net
Sun Aug 22 21:42:49 UTC 2010
Colin Watson wrote:
> On Thu, Aug 19, 2010 at 06:32:08PM +0200, Jim Meyering wrote:
>> Colin Watson wrote:
>> > There's no reason to impose any particular limit on loop labels, since
>> > they just represent a single large partition. Sector counts over 2^32
>> > are needed for large RAID arrays. Change the limit to 2^64 since that's
>> > the upper limit imposed by libparted and it saves us implementing the
>> > limit functions separately.
>> > * libparted/labels/pt-limit.gperf: Change limits on "loop" to 2^64.
>> > * tests/t9021-maxima.sh: Update for the new loop limit.
>> Thanks for the patch.
>> Do you know if this fixes a regression? I.e., did it ever work?
>> If so, it might be worthwhile to dig up where the bug
>> was introduced.
> I'm not absolutely certain, but I think it was broken by commit
> 2dbc645c39d6ef736dcf0e1825a6801f33371f65, which would make it a
> regression in Parted 2.1.
I thought so, too, but hadn't bisected (a few change sets
in the vicinity don't compile). I've adjusted the commit log to
reflect the probable origin, and added a note in the NEWS entry.
More information about the parted-devel