[parted-devel] [PATCH 1/4] libparted: Add legacy_boot flag to GPT PMBR (#754850)

[Brian C. Lane]

On Thu, Feb 02, 2012 at 04:35:19PM +0100, Jim Meyering wrote:
> Jim Meyering wrote:
> ...
> >> Thanks to you and Matthew for the patch.
> >> The new names are a little too generic -- i.e., what if some other
> >> legacy boot flag needs support in a different partition table type?
> >> So I've renamed the cpp symbols like this:
> >>
> >>   git grep -l LEGACY_BOOT|xargs perl -pi -e 's/_LEGACY_BOOT/_GPT_PMBR_BOOT/g'
> >>
> >> and manually changed the "legacy_boot" command argument to "pmbr_boot".
> >> I'll squash this into your 1/4 commit and update the log above.
> >
> > Whoops.
> > I need to restrict that change to the uses of _LEGACY_BOOT
> > with the PED_DISK prefix.  I don't want to change the
> > preexisting PED_PARTITION_LEGACY_BOOT name.
> >
> > This is yet another good reason for this renaming.
> >
> > I'll post the full series for review shortly.
> 
> Here's the 5-patch series.
> New to this list is 5/5 by Brian, which adds documentation,
> and 1/5, in which I've renames variables and the disk_set operand.
> Also, I've adjusted the tests, as mentioned already.
> I'll wait for an ACK from Brian or Matthew.

Ack, looks good. Thanks!

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20120202/d8f6f815/attachment.pgp>