[parted-devel] [PATCH 0/4] Add ability to set GPT PMBR boot flag

bcl at redhat.com bcl at redhat.com
Sat Jan 28 00:59:01 UTC 2012


Some BIOS systems refuse to boot from GPT disks unless the boot flag
of the PMBR has been set. Matthew Garrett has written a patch to add
a disk_set command and a legacy_boot flag for the disk. I have added
display of the disk flags using a new output line, like so:

Model:  (file)
Disk /home/bcl/disk.img: 4295MB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags: legacy_boot

Number  Start   End     Size    File system  Name       Flags
 1      1049kB  99.6MB  98.6MB               bootstuff

Or in machine mode:
BYT;
/home/bcl/disk.img:4295MB:file:512:512:gpt::legacy_boot;
1:1049kB:99.6MB:98.6MB::bootstuff:;

I have also updated existing tests so that they work properly with the
new output format as well as added a new test (t0208-gpt-legacy_boot.sh)

I am interested in feedback in this change, I am planning on adding it
to Fedora's rawhide release unless I hear any compelling objections or
other solutions for displaying the disk flags. I expect that it will
break things that expect precise output from parted instead of parsing
out what they need, but I think this method is the least disruptive.

Brian C. Lane (3):
  parted: print disk flags
  tests: update tests for new disk flags output
  tests: add test for GPT PMBR legacy_boot flag

Matthew Garrett (1):
  libparted: Add legacy_boot flag to GPT PMBR (#754850)

 NEWS                                            |   17 ++++
 include/parted/disk.h                           |    4 +-
 libparted/disk.c                                |    3 +-
 libparted/labels/gpt.c                          |   60 ++++++++++++-
 parted/parted.c                                 |  110 ++++++++++++++++++++++-
 parted/ui.c                                     |   29 ++++++
 parted/ui.h                                     |    3 +
 tests/Makefile.am                               |    1 +
 tests/t0010-script-no-ctrl-chars.sh             |    2 +-
 tests/t0100-print.sh                            |    1 +
 tests/t0101-print-empty.sh                      |    1 +
 tests/t0208-gpt-legacy_boot.sh                  |   38 ++++++++
 tests/t0220-gpt-msftres.sh                      |    2 +-
 tests/t0250-gpt.sh                              |    2 +-
 tests/t0280-gpt-corrupt.sh                      |    4 +-
 tests/t2310-dos-extended-2-sector-min-offset.sh |    2 +-
 tests/t4000-sun-raid-type.sh                    |    2 +-
 tests/t4100-dvh-partition-limits.sh             |    4 +-
 tests/t4100-msdos-partition-limits.sh           |    4 +-
 tests/t4100-msdos-starting-sector.sh            |    4 +-
 tests/t4200-partprobe.sh                        |    2 +-
 tests/t5000-tags.sh                             |    6 +-
 tests/t6000-dm.sh                               |    4 +-
 tests/t9040-many-partitions.sh                  |    2 +-
 tests/t9041-undetected-in-use-16th-partition.sh |    2 +-
 25 files changed, 282 insertions(+), 27 deletions(-)
 create mode 100755 tests/t0208-gpt-legacy_boot.sh

-- 
1.7.6.5




More information about the parted-devel mailing list