[parted-devel] [PATCH] libparted: Remove fdasd geometry code from alloc_metadata (#1244833)

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 04/12/2016 04:36 PM, Brian C. Lane wrote:
> commit db20944f changed how the trailing_metadata_end is calculated
> in dasd_alloc_metadata, removing the need for setting up the anchor
> struct. But dasd_alloc_metadata can be called in various contexts,
> and the arch_specific->fd may or may not be valid during these
> calls. This can result in unpredictable crashes when it uses a
> stale fd and tries to run the file image code in fdasd_get_geometry
> instead of the device code.
> 
> The solution is to just drop the unneeded code, and to remember
> that arch_specific->fd should only be used when ped_device_open has
> first been called.
> 
> Resolves: rhbz#1244833

I can't test this because I don't have an s360, but I'll assume you
have and it makes sense, so ACK.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCgAGBQJXEDW5AAoJEBB5UWFcu6UWCsAIAKmCtOMJi5dmiTmXtuvARvoS
XdJGsVhk6w9sV/IVpLpBxowyv7MSJXZb09knDrtgh8W3VeWUcdnejoEjwxLgmjVR
srwCrUF4fldlzfnT5sRelltxpVeMWYwkUtdxVZ2S33hFr1f9yKyNQ/1auuygzgAO
z+7M6VCw1027y1huEIZkpvbRktID4cTiVryN9RUOzgVezdkBed0hXzFexhyQQMUc
hkwHZGvsjjAqvcfL1Zy/t9V0sSaaDydl6sM90911t9GGmk4FMaCjV5Fl0Ow/qxhU
pNtembROLufAw+ZskGEkCLWuUm+731kOIn10lOOt2obxMuChF93dvYKacBQJehY=
=J2Fo
-----END PGP SIGNATURE-----