<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi,</p>
<p>I read the parted.c and got a question about function <b>do_mkpart.</b><br>
</p>
<p>Any errors from the low level will result in fail of function <b>ped_disk_commit,</b></p>
<p>then <b>do_mkpart</b> will jump directly to label<b> error</b>,
without processing the new part info in memory.</p>
<p> Why not just remove the new part info but leave it untouched?<br>
</p>
<p>I can get it if parted in script mode, then this may not affect
much, because parted will exit at once with fail.<br>
</p>
<p> but if it is in interactive mode, user still can see the part
info, this will be confusing.</p>
<p><br>
</p>
<p>The same situation exists in <b>ped_device_set_system</b>.</p>
<p>I think these two function should jump to label <b>error_remove_part</b>
not just label <b>error</b> once they fail.</p>
<p>Is this OK? Or something I missed. Any comments will be
appreciated. Thanks in advance.<br>
</p>
<br>
<pre class="moz-signature" cols="72">--
Best regards.
Wang Dong
</pre>
</body>
</html>