[Pbuilder-maint] Bug#342883: Incompatibility between pbuilder and devscripts WRT DEBEMAIL

[Loïc Minier]

Package: pbuilder, devscripts
Severity: normal

        Hi,

 pbuilder and the "bts" command seem to disagree on what "DEBEMAIL" is
 supposed to hold.

 /usr/lib/pbuilder/pbuilder-buildpackage is calling dpkg-buildpackage
 "-m$DEBEMAIL", and that implies DEBEMAIL should hold "Maintainer Name
 <maintainer-address@>",  and if you call the bts command with a
 DEBEMAIL formatted like this, you will get:
    From: Maintainer Name <Maintainer Name <maintainer-address@>>

 I've read the relevant bts snipset, and I believe there's no way to
 have a single environment and make both bts and pbuilder happy.

 I believe pbuilder should use something along the lines of:
    PBUILDER_DPKGBP_MAINTADDR="$DEBFULLNAME <$DEBEMAIL>"
 and bts should check for the correctness of the resulting From: line,
 or the validity of its input (eg search for [<>] in DEBFULLNAME or
 DEBEMAIL).

 Perhaps bts can be enhanced like this:
    foreach $env (qw(DEBFULLNAME DEBEMAIL EMAIL)) {
        if exists($ENV{$env}) {
            if ($ENV{$env} =~ /^(.*)\s+<(.*)>$/) {
                $name ||= $1;
                $email ||= $2;
            } else {
                $email ||= $ENV{$env};
            }
        }
    }
 de facto reading email or name from all environment variables in the
 order specified.

   Cheers,
-- 
Loïc Minier <lool at dooz.org>