[Pbuilder-maint] Bug#338976: pbuilder and /etc/shadow

Roland Stigge stigge at antcom.de
Tue Nov 15 23:20:38 UTC 2005


Norbert Preining wrote:
>>with this, you are just preventing the respective lines from being
>>executed. I guess you have BUILDUSERNAME unset (default)?
>>
>>Maybe we should also "cat >>" to etc/shadow etc. if it doesn't exist?
> 
> 
> Well, I didn't say that this is the right solution. But what is *TRUE*
> is that the check for -n is *WRONG* in any case, so it is useless to
> have this check! Why would there be a check for -n if the variable is
> either "su " or "su username"? In any case it is -n! So there is for
> sure a failure.

I guess dancer intended it for checking if the variable was set to
anything (assuming that the default case is "" instead of "su "). I.e.
in the default case without a special user, we wouldn't manipulate
etc/shadow et al. So your solution was even right, but for the wrong
problem... ;)




More information about the Pbuilder-maint mailing list