Bug#382977: [Pbuilder-maint] Bug#382977: fails to umount with internal pdebuild

[martin f krafft]

tags 382977 patch
thanks

also sprach Junichi Uekawa <dancer at netfort.gr.jp> [2006.08.16.1553 +0100]:
> I'm not sure if we have support for spaces in paths.  If we do, we
> probably need to care about escaping them.

Doesn't look like it:

pbuilder-checkparams:     BINDMOUNTS="${BINDMOUNTS} $2"
pbuilder-modules:    for mnt in $BINDMOUNTS; do


Here's the patch, and I've verified it.

--- pbuilder-checkparams  2006-07-26 00:39:52.000000000 +0100            
+++ /tmp/pbuilder-checkparams 2006-08-16 16:15:12.000000000 +0100
@@ -264,3 +264,5 @@
  ;;
 esac
 
+# sort BINDMOUNTS to ensure that deeper directories are mounted last
+BINDMOUNTS="$(for i in $BINDMOUNTS; do echo $i; done | sort -u)"



--- pbuilder-modules  2006-07-26 00:39:53.000000000 +0100
+++ /tmp/pbuilder-modules 2006-08-16 16:18:26.000000000 +0100
@@ -126,7 +126,13 @@
  fi
  umount_one "proc"
     fi
+    # push arguments on a stack to reverse direction
+    local reversed
+    reversed=''
     for mnt in $BINDMOUNTS; do
+      reversed="$mnt $reversed"
+    done
+    for mnt in $reversed; do
  umount_one "$mnt"
     done
 }

-- 
Please do not send copies of list mail to me; I read the list!
 
 .''`.     martin f. krafft <madduck at debian.org>
: :'  :    proud Debian developer and author: http://debiansystem.info
`. `'`
  `-  Debian - when you have better things to do than fixing a system
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature (GPG/PGP)
Url : http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20060816/9f8e48aa/attachment.pgp