Bug#382977: [Pbuilder-maint] Bug#382977: fails to umount with internal pdebuild

Junichi Uekawa dancer at netfort.gr.jp
Wed Aug 16 23:41:28 UTC 2006


Hi,

> --- pbuilder-checkparams  2006-07-26 00:39:52.000000000 +0100            
> +++ /tmp/pbuilder-checkparams 2006-08-16 16:15:12.000000000 +0100
> @@ -264,3 +264,5 @@
>   ;;
>  esac
>  
> +# sort BINDMOUNTS to ensure that deeper directories are mounted last
> +BINDMOUNTS="$(for i in $BINDMOUNTS; do echo $i; done | sort -u)"
> 
> 
> 
> --- pbuilder-modules  2006-07-26 00:39:53.000000000 +0100
> +++ /tmp/pbuilder-modules 2006-08-16 16:18:26.000000000 +0100
> @@ -126,7 +126,13 @@
>   fi
>   umount_one "proc"
>      fi
> +    # push arguments on a stack to reverse direction
> +    local reversed
> +    reversed=''
>      for mnt in $BINDMOUNTS; do
> +      reversed="$mnt $reversed"
> +    done
> +    for mnt in $reversed; do
>   umount_one "$mnt"
>      done
>  }

This looks good.
Could you commit with appropriate entries in:
ChangeLog
debian/changelog


regards,
	junichi
-- 
dancer@{debian.org,netfort.gr.jp}   Debian Project




More information about the Pbuilder-maint mailing list