Bug#333294: [Pbuilder-maint] Bug#333294: Info received (A patch for the default mirror)

[Eddy Petrișor]

On 05/03/2008, Junichi Uekawa <dancer at netfort.gr.jp> wrote:
> Hi,
>
>  Thanks for the patch, it looks promising.

Now is final (well, as always, there can be minor improvements, if I
look  at the code again), but it fixes the points you raised and some
other stuff.

>  > >>  /usr/share/pbuilder/pbuilderrc, and newer configuration variables will
>  > >>  be taken from there, so upgrade cases shouldn't cause too much
>  > >>  problem.
>  > >
>  > > Does pbuilder work properly if pbuilderrc is minimalistic (i.e.
>  > > contains only MIRRORSITE=...)?
>  > >
>  > > Then generating a minimal /etc/pbuilderrc with the default sources it
>  > > all that it takes to fix this bug (in the light of my existing work),
>  > > right?
>  >
>  > Still waiting.
>
>
> Looking at the patch, MIRRORSITE=_ will confuse users, maybe something
>  like
>  MIRRORSITE=http://you-have-broken-debconf-configuration.example.com/
>  will be more helpful in finding out what's gone wrong.

Done that replace. Also I changed that to say
"http://ftp.debian.org/debian" in the pbuilderrc that will be
installed as an example *and* in /usr/hare/pbuilder since with that
change pbuilder wouldn't have worked if there was no /etc/pbuilderrc
at all.

>  On the other hand, pbuilder will source /usr/share/pbuilder/pbuilderrc
>  before /etc/pbuilderrc, so you can actually leave /etc/pbuilderrc
>  mostly blank, and just fill in, say, MIRRORSITE only.

Done that change, too. Now also it detects and handles MIRRORSITE
specifications preceeded by spaces or tabs.

Also, the previous versions were replacing all MIRRORSITE entries at
once, including commented out entries, while if there were no active
entries, a configuration didn't result in a correct reconfiguration
that added one uncommented line.

All of these were corrected.

As usual, git repo at:
Web	http://git.debian.org/?p=users/eddyp-guest/pbuilder.git;a=summary
URL	git://git.debian.org/git/users/eddyp-guest/pbuilder.git
	http://git.debian.org/git/users/eddyp-guest/pbuilder.git

A summarizing patch is attached.


Thanks in advance and kudos for pbuilder.

-- 
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 333294.patch
Type: text/x-patch
Size: 14415 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20080306/5a9d233e/attachment-0001.bin