Bug#505695: pbuilder keeps silent when it fails copying files to --buildresult

[Junichi Uekawa]

At Fri, 14 Nov 2008 14:21:12 +0100,
Nicolas Chauvat wrote:
> 
> Package: pbuilder
> Version: 0.183
> Severity: normal
> Tags: patch
> 
> 
> I happen to have my --buildresult directory in ~/dist with /home NFS-mounted with rootsquash. On the host on which I build the package root cannot write to my home directory. It took me some time to realize that 'sudo pbuilder' had not the permission to write there because /usr/lib/pbuilder/pbuilder-buildpackage reads:
> 
>   cp -p "${BUILDPLACE}"/tmp/buildd/* "${BUILDRESULT}" 2>/dev/null || true
> 
> I have no idea why "|| true" was deemed a good idea, but I suggest to fix the above issue by 
> removing it, since it will print out a message when cp fails.

/tmp/buildd/directory/ will fail to copy, and that's what the 'true' is for.
Just removing it will break every invocation, so a better patch is required.