Bug#563281: test_pbuilder-checkparams fails it pbuilder is not installed

[Michael Bienia]

Package: pbuilder
Version: 0.195
Severity: important
Tags: patch
Justification: fails to build from source

Hello,

test_pbuilder-checkparams fails if pbuilder is not installed (e.g. when
building pbuilder inside a pbuilder or on the buildds).
The reason is that pbuilder-checkparams source files from
/usr/lib/pbuilder which aren't there (as pbuilder isn't installed). One
sees the error if the redirection of stderr in
test_pbuilder-checkparams:test_debuildopts() is temporarily commented out:
,----
| ./pbuilder-checkparams: line 24: /usr/lib/pbuilder/pbuilder-loadconfig: No such file or directory
| ./pbuilder-checkparams: line 25: /usr/lib/pbuilder/pbuilder-modules: No such file or directory
| ./pbuilder-checkparams: line 257: BUILDPLACE: Build root directory is not defined
`----
It seems to be sufficient to define BUILDPLACE before
pbuilder-checkparams is sourced (and continue to ignoring the error
about the non-existant files). With this change the testsuite works (and
succeeds).

Michael

diff -Nru pbuilder-0.195/test_pbuilder-checkparams pbuilder-0.195ubuntu1/test_pbuilder-checkparams
--- pbuilder-0.195/test_pbuilder-checkparams    2009-12-14 15:05:38.000000000 +0100
+++ pbuilder-0.195ubuntu1/test_pbuilder-checkparams     2010-01-01 19:13:35.000000000 +0100
@@ -7,6 +7,7 @@
 test_debuildopts() {
     # stderr is redirected to /dev/null to avoid failing if ~/.pbuilderrc is
     # missing (this outputs a warning which is not expected in the output)
+    BUILDPLACE=""
     . ./pbuilder-checkparams 2>/dev/null
     echo "$DEBBUILDOPTS"
 }