cowdancer, cowbuilder, and qemubuilder repository: Changes to 'master'
Junichi Uekawa
dancer at alioth.debian.org
Thu Mar 28 01:39:11 UTC 2013
Makefile | 2
cowbuilder.c | 19 +++++++
cowbuilder_util.c | 53 +++++++++++++++++++++
cowbuilder_util.h | 8 +++
debian/changelog | 8 +++
test_cowbuilder.c | 2
test_cowbuilder_util.c | 58 +++++++++++++++++++++++
tests/log/000_test_basic.sh.log | 30 +++++------
tests/log/001_test_symlink.sh.log | 34 ++++++-------
tests/log/002_test_open.sh.log | 26 +++++-----
tests/log/003_test_fopen.sh.log | 26 +++++-----
tests/log/004_test_fopen64.sh.log | 26 +++++-----
tests/log/010_test_noilistfile.sh.log | 4 -
tests/log/012_test_chown.sh.log | 32 ++++++------
tests/log/013_test_chmod.sh.log | 26 +++++-----
tests/log/014_ilistdump_test.sh.log | 8 +--
tests/log/015_test_ilistdelete.sh.log | 2
tests/log/016_memleakcheck.sh.log | 50 ++++++++++---------
tests/log/017_tempfilecheck.sh.log | 2
tests/log/018_testcxx.sh.log | 6 +-
tests/log/019_test_filename_with_space.sh.log | 28 +++++------
tests/log/020_test_lchown.sh.log | 40 +++++++--------
tests/log/022_kernel_waitpid.sh.log | 2
tests/log/101_test_qemubuilder_dumpconfig.sh.log | 2
tests/log/test_cowbuilder_util.c.log | 1
tests/log/test_file.c.log | 2
tests/log/test_qemuarch.c.log | 16 +++---
27 files changed, 331 insertions(+), 182 deletions(-)
New commits:
commit d05873856f67c4db97e8f4ad4fc5b33cac3d7eb8
Author: Junichi Uekawa <dancer at netfort.gr.jp>
Date: Thu Mar 28 10:38:02 2013 +0900
allocate string dynamically using alloca.
commit 7487258b7bb2e1004367cdfe1ff399f1a0be3cc3
Author: Junichi Uekawa <dancer at netfort.gr.jp>
Date: Wed Mar 27 23:41:00 2013 +0900
move out code to cowbuilder_util, and add test.
commit 203036070b907fe834f3d844c9fb97faa8bf857b
Author: Jean-Baptiste Lallement <jean-baptiste.lallement at canonical.com>
Date: Tue Mar 19 10:11:28 2013 +0100
Bug#703406: cowbuilder deletes content of bind-mounted directories
Package: cowdancer
Version: 0.71
Tags: patch
Reference issue in Ubuntu [1]
If a bind-mounted directory is still mounted during the clean-up phase
(device busy for example) cowbuilder unconditionally deletes its content.
Excerpt from a log with this bug (complete log attached)
=====
I: umounting /var/lib/jenkins/cu2d
umount: /var/cache/pbuilder/build/cow.15281/var/lib/jenkins/cu2d: device
is busy.
(In some cases useful info about processes that use
the device is found by lsof(8) or fuser(1))
[...]
-> Cleaning COW directory
forking: rm -rf /var/cache/pbuilder/build//cow.1195
rm: cannot remove
`/var/cache/pbuilder/build//cow.1195/var/cache/pbuilder/ccache': Device
or resource busy
rm: cannot remove
`/var/cache/pbuilder/build//cow.1195/var/lib/jenkins/cu2d/work/experimental/100scopes':
Device or resource busy
rm: cannot remove
`/var/cache/pbuilder/build//cow.1195/var/lib/jenkins/cu2d/launchpad.cache':
Directory not empty
=====
This bug occurs when pbuilder fails to mount a bindmounted directory,
then fails to unmount previously successfully mounted directories. This
condition is not so rare when executing several cowbuilder processes in
parallel using the same bind-mounted directories.
The attached patch has been proposed to Ubuntu and skips cleanup if
anything is mounted under the chroot.
[1] https://bugs.launchpad.net/ubuntu/+source/cowdancer/+bug/1156540
--
Jean-Baptiste
IRC: jibel
commit 3e3fff14f6ff159d72db50e64f4d171c636f6565
Author: Junichi Uekawa <dancer at netfort.gr.jp>
Date: Wed Mar 27 07:15:42 2013 +0900
test update
More information about the Pbuilder-maint
mailing list