Bug#802800: Passes -S unconditionally conflicting with '-g' when building the source package

[Guido Günther]

Hi,
On Mon, Nov 09, 2015 at 07:55:11PM +0000, Mattia Rizzolo wrote:
> control: tags -1 pending
> 
> On Fri, Nov 06, 2015 at 06:25:15PM +0100, Guido Günther wrote:
> > Hi,
> > we must not pass '-g' when building the source packge in pbuilder
> > otherwise we fail like below. Prove of concept patch attached.
> > 
> > The issus is actually in pbuilder itself:
> > 
> > $ pdebuild --buildresult ../ --pbuilder cowbuilder --debbuildopts  '-g'  -- --hookdir /home/foo/.pbuilder/hooks --basepath /var/cache/pbuilder/base-sid.cow
> > 0
> > I: using cowbuilder as pbuilder
> > dpkg-buildpackage: cannot combine -S and -g
> 
> Yeah, -g and -G are newer than pdebuild :P
> 
> >      echo "dpkg-buildpackage -S -d -us -uc -r${BUILDSOURCEROOTCMD} $DEBBUILDOPTS" | \
> >  	perl -pe 's/(^|\s)-[AbBF](\s|$)/$1$2/g' | \
> > +	perl -pe 's/(^|\s)'\''-g'\''(\s|$)/$1$2/g' | \
> 
> I instead added 'G' and 'g' to that [AbBF] "array" :)

If you do so you also need to allow the valus to be surrounded by single
quotes ('). That's why I added a second line, to show how the value gets
passed in.

> Committed locally, I wanted to upload a new pbuilder last week, guess
> I'll do this one.

Great! but please also allow for the value to be enclodes in single
quotes (as git-pbuilder does to make sure the spaces are passed on
correctly).

Thanks for looking into this,
 -- Guido