Bug#805392: pbuilder: debdelta-upgrade invocation seems incorrect

[Ritesh Raj Sarraf]

Hello Mattia,

On Tue, 2015-11-17 at 19:52 +0000, Mattia Rizzolo wrote:
> I wonder why, given that I tested it, but indeed this has little
> chances
> to work correctly: hash is a bash keyword, but bash is not called in
> there.
> 
> can you please try to locally apply
> 
> --- a/pbuilder-updatebuildenv
> +++ b/pbuilder-updatebuildenv
> @@ -73,7 +73,7 @@ recover_aptcache
>  
>  $TRAP saveaptcache_umountproc_cleanbuildplace_trap exit sighup
>  if [ "$DEBDELTA" = "yes" ]; then
> -    if $CHROOTEXEC hash debdelta-upgrade 2> /dev/null ; then
> +    if $CHROOTEXEC bash -c "hash debdelta-upgrade 2> /dev/null" ;
> then
>          log.i "Using debdelta-upgrade for available deltas"
>          if $CHROOTEXEC debdelta-upgrade ; then
>              :

That seems to be the correct root cause.

Get:32 http://ftp.debian.org sid/non-free amd64 2015-11-16-
2042.09.pdiff [466 B]
Get:33 http://ftp.debian.org sid/main 2015-11-17-2042.33.pdiff [1134 B]
Get:34 http://ftp.debian.org sid/main 2015-11-18-0242.47.pdiff [2611 B]
Get:35 http://ftp.debian.org sid/main 2015-11-18-0242.47.pdiff [2611 B]
Fetched 525 kB in 8s (63.7 kB/s)
Reading package lists...
I: Using debdelta-upgrade for available deltas
Created,    time  0.29sec, speed 156kB/sec,
libdebconfclient0_0.196_amd64.deb                  
Created,    time  0.74sec, speed 76kB/sec, libsigc++-2.0-0v5_2.6.2-
1_amd64.deb                 
Downloaded, time  0.36sec, speed 86kB/sec, libcloog-isl4_0.18.3-
1_0.18.4-1_amd64.debdelta      
Created,    time  0.22sec, speed 276kB/sec, libcloog-isl4_0.18.4-
1_amd64.deb                   
Downloaded, time  0.53sec, speed 303kB/sec, libgmp10_2%3a6.0.0+dfsg-
7_2%3a6.1.0+dfsg-2_amd64.debdelta
Created,    time  0.53sec, speed 468kB/sec, libgmp10_2%3a6.1.0+dfsg-
2_amd64.deb                
Delta-upgrade
statistics:                                                            
          
 total resulting debs, size 411kB time 4sec virtual speed 82kB/sec
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
  libisl15
The following packages will be upgraded:
  libcloog-isl4 libdebconfclient0 libgmp10 libsigc++-2.0-0v5
4 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 532 kB/953 kB of archives.
After this operation, 1803 kB of additional disk space will be used.
Get:1 http://ftp.debian.org/debian/ sid/main libisl15 amd64 0.15-3 [532
kB]
Fetched 532 kB in 1s (461 kB/s)

-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20151118/5e92c6de/attachment.sig>