Bug#827206: pbuilder: pre-installed eatmydata removed

[Mattia Rizzolo]

On Mon, Jun 13, 2016 at 05:56:40PM +0000, Thorsten Glaser wrote:
> >As a side effect of fixing #606158 / adding a new EATMYDATA variable,
> 
> ugh, that breaks a lot of things. For example, it adds the binary
> and fails if the binary is not installed.

emh, -eparse.
If the binary is not installed it just disables eatmydata... (yes, if
the binary fails to install it fails, but that's true with everything in
EXTRAPACKAGES, nothing new and i hope expected).

can you be more verbose on what it breaks?

> I have a wrapper script that invokes cowbuilder with the library
> already.

so i used to have.
I probably forgot to test it by having EATMYDATA=no and the calling the
whole thing with eatmydata...
(but I did test having EATMYDATA=yes and *also* wrapping the whole thing
manually)

> Can you please just disable all eatmydata handling in pbuilder
> (install, remove, use) if [[ $LD_PRELOAD = *eatmydata* ]] ?

that would be ugly, expecially considering how the thing is wired in.

I can (and probably will) change remove_package() to not remove packages
that are also list in EXTRAPACKAGES (so, giving EXTRAPACKAGES a
"precedence" over REMOVEPACKAGES, currently it's undefined and it relies
on what's done before, that i could accidentally change without even
noticing..).  This is what this bug is about and indeed it's a bug which
I'll fix.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20160613/add05c82/attachment.sig>