Bug#859178: pbuilder: source-only changes doesn't handle -sa passed to pbuilder --debbuildopts

[James Clarke]

On 20 Apr 2017, at 11:04, Yves-Alexis Perez <corsac at debian.org> wrote:
> On Sat, 2017-04-08 at 15:58 +0200, Mattia Rizzolo wrote:
>> Is what you are observing specific to linux-grsec?  I'd be mostly
>> surprised by it.
> 
> Maybe. And maybe the bug doesn't lie in pbuilder but dpkg-genchanges, I'm not
> sure. The build log can be found at https://perso.corsac.net/~corsac/debian/li
> nux-grsec_4.9.18-1+grsec201703261106+1_amd64.build and we can see:
> 
> I: Running cd /build/linux-grsec-4.9.18/ && env
> PATH="/usr/lib/ccache:/usr/sbin:/usr/bin:/sbin:/bin" HOME="/nonexistent" dpkg-
> buildpackage -us -uc  -I -d -sa -rfakeroot && env
> PATH="/usr/lib/ccache:/usr/sbin:/usr/bin:/sbin:/bin" HOME="/nonexistent" dpkg-
> genchanges -S '-sa' > ../linux-grsec_4.9.18-
> 1+grsec201703261106+1_source.changes

What's in your B10_source-build hook? Looking closely at the log:

> make[1]: Leaving directory '/build/linux-grsec-4.9.18'
>  dpkg-genbuildinfo
>  dpkg-genchanges -sa >../linux-grsec_4.9.18-1+grsec201703261106+1_amd64.changes
> dpkg-genchanges: info: including full source code in upload

This is the binary dpkg-genchanges done by dpkg-buildpackage

>  dpkg-source -I --after-build linux-grsec-4.9.18
> dpkg-source: info: using options from linux-grsec-4.9.18/debian/source/options: --compression=xz --tar-ignore=debian/*.local
> dpkg-buildpackage: info: full upload (original source is included)
> dpkg-genchanges: info: including full source code in upload

This is the source-only dpkg-genchanges done by pbuilder, *with* -sa.

> I: copying local configuration
> I: user script /var/cache/pbuilder/build/23492/tmp/hooks/B10_source-build starting
> Generating source changes file
> dpkg-genchanges: info: not including original source code in upload

I imagine B10_source-build is overwriting the _source.changes pbuilder just
generated.

Regards,
James