[Pcsclite-cvs-commit] r6558 - /trunk/PCSC/src/ifdwrapper.c
rousseau at users.alioth.debian.org
rousseau at users.alioth.debian.org
Wed Mar 6 14:12:49 UTC 2013
Author: rousseau
Date: Wed Mar 6 14:12:49 2013
New Revision: 6558
URL: http://svn.debian.org/wsvn/pcsclite/?sc=1&rev=6558
Log:
cppcheck: Variable 'rv' is reassigned a value before the old one has
been used.
This is a (minor) performance issue. I guess the compiler can optimize
the code as needed.
Modified:
trunk/PCSC/src/ifdwrapper.c
Modified: trunk/PCSC/src/ifdwrapper.c
URL: http://svn.debian.org/wsvn/pcsclite/trunk/PCSC/src/ifdwrapper.c?rev=6558&op=diff
==============================================================================
--- trunk/PCSC/src/ifdwrapper.c (original)
+++ trunk/PCSC/src/ifdwrapper.c Wed Mar 6 14:12:49 2013
@@ -46,7 +46,7 @@
LONG IFDSetPTS(READER_CONTEXT * rContext, DWORD dwProtocol, UCHAR ucFlags,
UCHAR ucPTS1, UCHAR ucPTS2, UCHAR ucPTS3)
{
- RESPONSECODE rv = IFD_SUCCESS;
+ RESPONSECODE rv;
#ifndef PCSCLITE_STATIC_DRIVER
RESPONSECODE(*IFDH_set_protocol_parameters) (DWORD, DWORD, UCHAR,
@@ -141,7 +141,7 @@
*/
LONG IFDCloseIFD(READER_CONTEXT * rContext)
{
- RESPONSECODE rv = IFD_SUCCESS;
+ RESPONSECODE rv;
int repeat;
#ifndef PCSCLITE_STATIC_DRIVER
@@ -183,7 +183,7 @@
LONG IFDSetCapabilities(READER_CONTEXT * rContext, DWORD dwTag,
DWORD dwLength, PUCHAR pucValue)
{
- RESPONSECODE rv = IFD_SUCCESS;
+ RESPONSECODE rv;
#ifndef PCSCLITE_STATIC_DRIVER
RESPONSECODE(*IFDH_set_capabilities) (DWORD, DWORD, DWORD, PUCHAR) = NULL;
@@ -214,7 +214,7 @@
LONG IFDGetCapabilities(READER_CONTEXT * rContext, DWORD dwTag,
PDWORD pdwLength, PUCHAR pucValue)
{
- RESPONSECODE rv = IFD_SUCCESS;
+ RESPONSECODE rv;
#ifndef PCSCLITE_STATIC_DRIVER
RESPONSECODE(*IFDH_get_capabilities) (DWORD, DWORD, PDWORD, /*@out@*/ PUCHAR) = NULL;
@@ -317,7 +317,7 @@
*/
LONG IFDStatusICC(READER_CONTEXT * rContext, PDWORD pdwStatus)
{
- RESPONSECODE rv = IFD_SUCCESS;
+ RESPONSECODE rv;
DWORD dwCardStatus = 0;
#ifndef PCSCLITE_STATIC_DRIVER
@@ -487,7 +487,7 @@
PUCHAR pucTxBuffer, DWORD dwTxLength, PUCHAR pucRxBuffer,
PDWORD pdwRxLength, PSCARD_IO_HEADER pioRxPci)
{
- RESPONSECODE rv = IFD_SUCCESS;
+ RESPONSECODE rv;
#ifndef PCSCLITE_STATIC_DRIVER
RESPONSECODE(*IFDH_transmit_to_icc) (DWORD, SCARD_IO_HEADER, PUCHAR,
More information about the Pcsclite-cvs-commit
mailing list