Bug#651711: perl: Check that git exists before trying to use it

[Dominic Hargreaves]

Source: perl
Version: 5.14.2-6
Severity: minor

Without this check, a build run from a git repository without git
being available may result in PERL_GIT_UNCOMMITTED_CHANGES being
defined incorrectly.

My workflow was to build directly from the Debian git repository from
a clean sid chroot, which was causing these to be shown up. Now I export
the source directory first, to avoid this problem.

One disadvantage of this patch is that it may mask real changes which
were made in a local repository if built without git available; if this
was deemed problematic, I think we would instead patch out the git
checks in the Debian package entirely.

I was going to send this straight to perlbug, but I thought that it would
be worth disucssing locally because it's such an edge case which has a
bigger impact for most on us -- and because of the problem noted above.

Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Check-that-git-exists-before-trying-to-use-it.patch
Type: text/x-diff
Size: 995 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/perl-maintainers/attachments/20111211/636912f0/attachment.patch>