Bug#660195: perl: Makefile.PL arguments not passed to recursive invocations

[Niko Tyni]

On Sat, Feb 25, 2012 at 10:06:29PM +0200, Niko Tyni wrote:
> On Sat, Feb 25, 2012 at 03:39:43PM +0200, Niko Tyni wrote:
> > On Fri, Feb 17, 2012 at 12:19:28PM +0200, Niko Tyni wrote:
> > > Package: perl
> > > Version: 5.14.2-7
> > > Forwarded: https://rt.cpan.org/Public/Bug/Display.html?id=28632
> > > 
> > > As noted in #657853, Makefile.PL command line arguments like OPTIMIZE and
> > > LD aren't passed down to recursive invocations when there are Makefile.PL
> > > files in subdirectories. This is hindering the adoption of hardening
> > > build flags.

I should have looked at this a bit more in the first place. OPTIMIZE
actually does get passed through, albeit in a somewhat different way:
the top level Makefile uses the sub-Makefiles with something like
 $(MAKE) OPTIMIZE=$(OPTIMIZE)
which overrides the settings inside the sub-Makefiles themselves.

LD isn't passed through, though.

> The attached patch whitelists LD and OPTIMIZE.

Turns out that there's another whitelist that implements the above,
and as noted it already includes OPTIMIZE. So just adding LD to
that seems cleaner. Revised patch attached.

> The next step could be finding out which XS module packages have
> more than one Makefile.PL inside and testing those.

This still applies.
-- 
Niko Tyni   ntyni at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-EU-MM-pass-LD-through-to-recursive-Makefile.PL-.patch
Type: text/x-diff
Size: 1497 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/perl-maintainers/attachments/20120226/c21c5526/attachment.patch>