Bug#754054: perl: FTBFS on mips: Bad mojo! at make_patchnum.pl line 111.

[Niko Tyni]

clone 754054 -1
retitle -1 perl: erroneous quoting in Makefile.SH
submitter -1 Kristoffer Grundström <kristoffer.grundstrom1983 at gmail.com>
severity -1 minor
thanks

On Mon, Jul 07, 2014 at 07:28:24AM +0200, Kristoffer Grundström wrote:
> Isn't the LD_LIBRARY_PATH Line written somewhat wrong?
> 
> Why /perl\-sdOt09/perl\-5.18.2 ?

Yeah, thanks for noticing. It seems to be a bit overly quoted. I don't
think that hurts, as it gets expanded by the shell. I see it's been that
way since 5.17.6.

 http://perl5.git.perl.org/perl.git/commitdiff/937aac54e77dcd55bbcad956420c9f990fc0b4ea

quote() in Makefile.SH looks like it's supposed to leave '-' unquoted
(and quote '\'), there's probably a bug in the regexp. Cloning. I'm pretty
sure that's not the problem here, though.

 echo "$1" | sed 's/\([^a-zA-Z0-9.:_\-\/]\)/\\\1/g' ;;

should possibly be

 echo "$1" | sed 's/\([^a-zA-Z0-9.:_\/-]\)/\\\1/g' ;;
-- 
Niko Tyni   ntyni at debian.org