Bug#825378: perl: freeze on parsing (broken) code

[Dominic Hargreaves]

On Sun, May 29, 2016 at 12:09:17AM +0300, Yuriy M. Kaminskiy wrote:
> On 28.05.2016 17:50, Dominic Hargreaves wrote:
> >On Thu, May 26, 2016 at 04:47:07PM +0100, Dominic Hargreaves wrote:

> >>Just to note that I can confirm that it we get a syntax error on
> >>wheezy (so this is a regression for jessie).

> >>I bisected this using something like:
> >>
> >>cat ../test_prog.sh
> >>#!/bin/sh
> >>
> >>./perl -e 's{foo}{$h->X({->aaa=>"b"},$d)}ge;'
> >>
> >>if [ $? = 255 ]; then
> >>     exit 0
> >>fi
> >>
> >>../perl/Porting/bisect.pl --expect-fail --start v5.20.0 --end v5.22.0 --timeout 2 -- ../test_prog.sh
> >>
> >>This was fixed upstream by f8a7ccebba5637bf0cf5a23cea563b2ccd62312d[1],
> >>which as you observed was first included in 5.22.0. It may be a candidate
> >>for backporting to jessie / maint-5.20 upstream, but the patch doesn't
> >>apply as-is.
> >
> >Just to add to this: since perl 5.20 is out of support upstream, and
> >this isn't a critical issue, I suspect not much more will happen on
> >this bug from me. If someone else wants to backport the patch, I'd
> >happily consider it for inclusion in a future stable update.
> 
> Something like attached? (only complication: lack of op_sibling_splice in
> 5.20).
> Compiled with pbuilder (BTW, needed USENETWORK=yes; otherwise it failed two
> tests for IO::Socket::IP; looks like #759799?), minimally tested, seems
> work.
> Disclaimer: use with care/review carefully/IANAPH.

Thanks for the backporting! I've forwarded this upstream for review.

Best wishes,
Dominic.