Bug#825018: perl: FTBFS on hurd-i386: hardcoded E2BIG errno value

Samuel Thibault sthibault at debian.org
Sun Jun 5 11:02:43 UTC 2016


Dominic Hargreaves, on Sun 05 Jun 2016 11:57:24 +0100, wrote:
> On Sat, Jun 04, 2016 at 02:20:08PM +0100, Dominic Hargreaves wrote:
> > Control: severity -1 minor
> > Control: retitle -1 perl: flawed test: hardcoded E2BIG errno value
> > 
> > On Sun, May 29, 2016 at 02:23:52AM +0200, Samuel Thibault wrote:
> > > Dominic Hargreaves, on Sat 28 May 2016 16:50:41 +0100, wrote:
> > > > print "errno 7 stringifies to '$!'\n";
> > > > dom at exodar:~$ ./test.pl 
> > > > errno 7 stringifies to '(os/kern) not receiver'
> > > > 
> > > > but because that error message is also long enough, the test passes.
> > > > Can you shed any more light about how to reproduce this test failure?
> > > 
> > > Ah, that was most probably another consequence of #825020, giving me "7"
> > > (thus too short) instead of the error message.
> > 
> > Aha, that makes sense. So I've retitled and downgraded the bug
> > appropriately since it shouldn't now be the cause of a FTBFS. I'll
> > forward upstream - the test is clearly buggy (in at least two regards,
> > one of which cancels out the other).
> 
> It is apparent based on the upstream discussion at
> <https://rt.perl.org/Ticket/Display.html?id=128319> that we misunderstood
> the intent of the test; there is in fact no bug here.

Ok, I see, they don't need to care what error 7 maps to, and even if
it's not a valid errno value, one gets "Unknown error", which passes the
test.

So I agree it's alright, and actually properly tested whether
stringification was working (which was precisely the bug here :)

Samuel




More information about the Perl-maintainers mailing list